Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compose recipient input search logic #1741

Open
ioanmo226 opened this issue Jul 7, 2022 · 5 comments
Open

Update compose recipient input search logic #1741

ioanmo226 opened this issue Jul 7, 2022 · 5 comments
Milestone

Comments

@ioanmo226
Copy link
Collaborator

ioanmo226 commented Jul 7, 2022

When user searches for contact in compose recipient input, it takes 1-5 seconds for search results to come in our iOS app (this applies to browser extension and android app too).
But in gmail ios/android/web app, it takes less than 0.1 seconds for searching contacts.

Maybe we need to download contacts periodically and save them in realm cache?
This needs to be discussed I think.

@ioanmo226 ioanmo226 added this to the discussion milestone Jul 7, 2022
@tomholub
Copy link
Collaborator

tomholub commented Jul 7, 2022

Would be good to find out why is it that it takes so long. Is the API call so slow? Are we calling more than once? etc.

@ioanmo226
Copy link
Collaborator Author

it's google contact search api call request time

@ioanmo226
Copy link
Collaborator Author

we only call once

@tomholub
Copy link
Collaborator

tomholub commented Jul 7, 2022

ok. On browser extension, we actually do keep a cache and it should be a lot faster the second time. Is it not? Maybe we don't currently cache all, but only cache items that the user actually used. If that's the case, we could start caching all on browser extension too.

@ioanmo226
Copy link
Collaborator Author

this case i think

but only cache items that the user actually used``

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants