Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect instructions in readme regarding updating sub project deps #26

Open
Steve-Mcl opened this issue Sep 13, 2023 · 0 comments
Open
Labels
needs-triage Needs looking at to decide what to do

Comments

@Steve-Mcl
Copy link
Contributor

Steve-Mcl commented Sep 13, 2023

Current Behavior

The readme states

Changing a repos dependencies
Do not run npm install in one of the repository directories under packages.

If you do, you'll need to delete the node_modules directory that gets created.

If you need to modify a repository's dependencies:

Edit its package.json to add the dependencies in the normal way
Run npm install in the root of this repository.

Since NPM workspaces are no longer used, this is incorrect.

Running npm install does not install sub package dependencies. It is now necessary to run npm install inside (for example) packages/flowforge

This however replaces the sym links with actual NPM package installs - which can catch you off guard if you are making changes across multiple repositories

Before running npm i in a sub package dir

image

After running npm i in a sub package dir

image

NOTE:

This might be a windows only thing? Will need a MAC and LINUX try-out before committing to a solution.

Expected Behavior

Either the docs should be update to reflect new practices or npm install in dev-env should have a post script to do npm install across all sub packages & then run npm run link

Steps To Reproduce

No response

Environment

  • FlowForge version: NA
  • Node.js version: v16.18.1
  • npm version: 9.8.1
  • Platform/OS: Windows 11
  • Browser: NA
@Steve-Mcl Steve-Mcl added the needs-triage Needs looking at to decide what to do label Sep 13, 2023
@Pezmc Pezmc self-assigned this Sep 13, 2023
@Pezmc Pezmc removed their assignment Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Needs looking at to decide what to do
Projects
None yet
Development

No branches or pull requests

2 participants