From 5193293177eb48c797ebc81ce4dc17cbc51265c7 Mon Sep 17 00:00:00 2001
From: AlexPForgeFlow <alex.paris@forgeflow.com>
Date: Thu, 9 May 2024 10:11:46 +0200
Subject: [PATCH] [FIX] account_move_line_rma_order_line: remove security group
 group_account_move_rma_order_line + clean up commented code

---
 account_move_line_rma_order_line/__manifest__.py       |  4 +---
 .../security/account_security.xml                      | 10 ----------
 .../tests/test_account_move_line_rma_order_line.py     |  9 ---------
 3 files changed, 1 insertion(+), 22 deletions(-)
 delete mode 100644 account_move_line_rma_order_line/security/account_security.xml

diff --git a/account_move_line_rma_order_line/__manifest__.py b/account_move_line_rma_order_line/__manifest__.py
index 01ddade0f..443c256ae 100644
--- a/account_move_line_rma_order_line/__manifest__.py
+++ b/account_move_line_rma_order_line/__manifest__.py
@@ -10,9 +10,7 @@
     "category": "Generic",
     "depends": ["stock_account", "rma_account"],
     "license": "AGPL-3",
-    "data": [
-        "security/account_security.xml",
-    ],
+    "data": [],
     "installable": True,
     "maintainers": ["ChisOForgeFlow"],
     "development_status": "Beta",
diff --git a/account_move_line_rma_order_line/security/account_security.xml b/account_move_line_rma_order_line/security/account_security.xml
deleted file mode 100644
index ea986f4db..000000000
--- a/account_move_line_rma_order_line/security/account_security.xml
+++ /dev/null
@@ -1,10 +0,0 @@
-<?xml version="1.0" encoding="utf-8" ?>
-<odoo>
-
-    <record id="group_account_move_rma_order_line" model="res.groups">
-        <field name="name">Rma Order Line in Journal Items</field>
-        <field name="category_id" ref="base.module_category_hidden" />
-        <field name="users" eval="[(4, ref('base.user_root'))]" />
-    </record>
-
-</odoo>
diff --git a/account_move_line_rma_order_line/tests/test_account_move_line_rma_order_line.py b/account_move_line_rma_order_line/tests/test_account_move_line_rma_order_line.py
index 20568bd42..4d6328b6a 100644
--- a/account_move_line_rma_order_line/tests/test_account_move_line_rma_order_line.py
+++ b/account_move_line_rma_order_line/tests/test_account_move_line_rma_order_line.py
@@ -97,7 +97,6 @@ def _create_account(cls, acc_type, name, code, company, reconcile=False):
     @classmethod
     def _create_product(cls):
         """Create a Product."""
-        #        group_ids = [group.id for group in groups]
         product_ctg = cls.product_ctg_model.create(
             {
                 "name": "test_product_ctg",
@@ -171,16 +170,8 @@ def _create_rma(cls, products2move, partner):
                     "partner_id": move.partner_id.id,
                 }
             )
-            # data = wizard._prepare_rma_line_from_stock_move(move)
             wizard.add_lines()
 
-            # CHECK ME: this code duplicate rma lines, what is the porpourse?
-            # if move.product_id.rma_customer_operation_id:
-            #     move.product_id.rma_customer_operation_id.in_route_id = False
-            # move.product_id.categ_id.rma_customer_operation_id = False
-            # move.product_id.rma_customer_operation_id = False
-            # wizard._prepare_rma_line_from_stock_move(move)
-            # cls.line = cls.rma_line_model.create(data)
         return rma_id
 
     def _get_balance(self, domain):