-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apply name-scheme to windows #115
Comments
I noticed that now there is no mention of conda in the filename, could it be added back? my reasoning is to make it easier to direct newbies to download and test conda or libpack versions when trying to diagnose an issue, I could go to the release page and grab a direct link, but the link wouldn't last long and it's much easier for me to copy the release page link I have bookmarked. |
ok i add it back. so we have: |
i also noticed that their is no windows version listed this week? at all |
I am working on it, sry. |
No problem just was letting you know, just learning github not sure this was the best place to let you know |
@looooo IMO it would be better to keep the naming stable since at least one downstream distribution system depends on these names, see chocolatey-community/chocolatey-packages#1922 |
for reference here's where the magic happens: https://github.com/FreeCAD/FreeCAD-Bundle/blob/master/conda/scripts/get_freecad_version.py consider changing
to
if redbaron2 agrees |
@adrianinsaval |
@looooo lets make a note to remember to give @RedBaron2 a heads up if changes are made to naming schemes + new releases ? |
note that we are already doing 0.21 dev releases |
@RedBaron2 will you consider providing v0.21 weekly dev builds via chocolatey ? |
@RedBaron2 the version file is from the source creation action. this is done multiple times a day. The bundles are only done 2 times a week (Thursday and Sunday). So this is expected. |
@luzpaz @adrianinsaval |
@looooo from my understanding the major.minor version was removed from the filename to allow users seamless appimages updates for next versions, is so then there is no real need to remove them from the windows build, can we go back to having that in the windows filename? It would simplify stuff in chocolatey: chocolatey-community/chocolatey-packages#1948 (comment) @RedBaron2 the minor version changes about once a year, recent dev cycles have been longer and this time it's probably going to be longer too, |
@adrianinsaval The only issue will be that the Release Notes URL will be something like |
the current format is |
@adrianinsaval |
I suggest adding -dev in the chocolatey package only as it is redundant to point out in the filename, for now I made a PR with let me know if you actually need |
@adrianinsaval The File Name currently is Sorry for the confusion |
Ooooh ok, I thought we had to change something here, that's perfectly acceptable, I'll close that PR then. |
@adrianinsaval and the Release NOtes url being off is NOT an Issue for you?_? |
@adrianinsaval |
@RedBaron2 the dev releases now appear to come in two versions, one built against python 3.8 (win7 compatible) and another built against python 3.10, does this cause any issue with the chocolatey packaging? |
@adrianinsaval |
@adrianinsaval |
the filename should look like this:
FreeCAD_{{ release }}-{{ revision }}-{{ date }}-{{ system }}-{{ python-version }}.{{ extension }}
The text was updated successfully, but these errors were encountered: