Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Way to dismiss videos or mark them as "Not Interested" #1362

Open
ghost opened this issue May 28, 2021 · 15 comments
Open

Way to dismiss videos or mark them as "Not Interested" #1362

ghost opened this issue May 28, 2021 · 15 comments
Labels

Comments

@ghost
Copy link

ghost commented May 28, 2021

It would be great if there was a way to mark videos as "Not Interested" (to watch) or a way to dismiss or hide them.

Currently I hide watched videos. If there's a video in my feed I don't want to watch I mark is as read to make it disappear, but it messes up with my watch history. It would be great if there was an option to just hide videos without marking them as watched.

@ghost ghost added the enhancement New feature or request label May 28, 2021
@lagapi
Copy link

lagapi commented Sep 11, 2021

I believe something to easily mark a video as watched or non interesting would be very useful. The same way we have a star button at the right of every thumbnail video, it could be added another button in the left part for this. Maybe a little circle like the read/unread button from thunderbird.

@pseudomonas
Copy link

I don't want to hide watched videos (I like to re-watch) but sometimes there's a video with a thumbnail or title that I find distressing, and while on YouTube it's easy to hide, on Freetube it reqiuires workarounds.

There might need to be some kind of interface to undo the hiding, though I guess this could be just a button in the settings that removes all videos from being hidden, similar to deleting all history and marking all videos as unwatched?

@kommunarr
Copy link
Collaborator

kommunarr commented Nov 21, 2023

We now have #4228 that lets you use the video dropdown options to hide a channel that will be coming out in our next release, but it won't instantly remove that channel's videos from view if you're looking at it from inside a playlist, History, Subscriptions, or you're on that channel's page. The implementation for this would look somewhat different from a maintenance perspective, though, as that is a tougher nut to crack.

There might need to be some kind of interface to undo the hiding, though I guess this could be just a button in the settings that removes all videos from being hidden, similar to deleting all history and marking all videos as unwatched?

This sounds reasonable, but if someone were to something that they didn't want to add (e.g., by accident, or change of mind), they would have to open the floodgates. Would showing the titles of banned videos in a certain spot in Settings (that the user can click to unhide) like how we do it with our "Hide Videos From Channels" feature in our Distraction Free Settings be acceptable?

Screenshot_20231121_174707

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Nov 21, 2023

Maybe a weirs suggestion but

What about adding the whole title of the video to the blacklist by clicking on a hide video button in the dropdown options in the same manner as hide channel

@kommunarr
Copy link
Collaborator

@efb4f5ff-1298-471a-8973-3d47447115dc I can see why you're saying that as that would be very easy to implement after #4202, but I am a bit worried about the imperfections of that solution w.r.t. unintuitive and undesirable byproducts of it (e.g., you block a video titled "a", and now you can't see most videos, or the title is a generic one word like "Music" and you now stop seeing videos with that in the title).

@pseudomonas
Copy link

I think if I were implementing this, from looking a little at the code, I'd copy the "history"/"watched" mechanism so one could have a parallel to .historyEntryExists() and .markAsWatched() methods.

Then one could hide videos on the hidden list as though one was hiding already-watched videos.

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Nov 22, 2023

@efb4f5ff-1298-471a-8973-3d47447115dc I can see why you're saying that as that would be very easy to implement after #4202, but I am a bit worried about the imperfections of that solution w.r.t. unintuitive and undesirable byproducts of it (e.g., you block a video titled "a", and now you can't see most videos, or the title is a generic one word like "Music" and you now stop seeing videos with that in the title).

What about when you press on hide video button it adds it to the blacklist based on video url? The url gets converted in the blacklist just like how its done with channels and what the user gets to see is the title of the video.

To make it more clear what that title means we could add the channel name and icon before the title

So Channel Icon + Channel Name + Video title

@pseudomonas
Copy link

pseudomonas commented Nov 22, 2023

What about when you press on hide video button it adds it to the blacklist based on video url?

I can't think of a way that this differs from the functionality that I'm asking for (so long as there is only one canonical URL per video), apart from the extremely tenuous edge-case of "someone has a video title that contains another video's URL" and I'm not sure I've ever seen anyone doing that. They might include the other URL in the video description but blacklisting doesn't take that into account, right?

Am I right in thinking that blacklisting a video hides it both from the subscription list, and from the related-videos list? (this seems to me the desirable behaviour.)

@kommunarr
Copy link
Collaborator

What about when you press on hide video button it adds it to the blacklist based on video url?

Yes, saving the video ID should always work to my knowledge. We'll be checking a specific field for this, so no edge cases around titles either.

Am I right in thinking that blacklisting a video hides it both from the subscription list, and from the related-videos list? (this seems to me the desirable behaviour.)

For blacklisting a video using this feature, yes, that would be necessary. We would have to hide it just about everywhere to achieve the same "get out of my sight" effect. One remaining question is whether we still hide it in your History or Favorites if you saved it to either of them. I'm leaning towards hiding it from History, but not Favorites. Another remaining question is if we make the video a "video hidden" list item that you can click on to unhide, either only for that very page you block it (which is how YT handles it, to my knowledge) or ad infinitum (whenever you chance upon it).

@kommunarr
Copy link
Collaborator

Huh, apparently, YT's version of this Hide feature is a lot more limited than I'm suggesting - applies to Subscriptions and Recommended Videos, but nowhere else as far as I can tell. Not even search results. You can't do it in playlists either, but it at least seems to respect the hiding of them there. We might have to consider that in our implementation - at least w.r.t. the question of whether to hide things on Channel pages. But our feature will most likely be more expansive than theirs in terms of affected views, and views where you're presented with that choice. I also didn't see anything on where you could clear your hidden videos, which was pretty enlightening as well.

@lamborghinipth
Copy link

When will this feature be implemented?

@lamborghinipth
Copy link

No one need this feature, doesnt it?

@pseudomonas
Copy link

I'm confused, I thought you were nagging other people to fix this but you're one of the contributors?

@lamborghinipth
Copy link

I'm confused, I thought you were nagging other people to fix this but you're one of the contributors?

No, I am not a contributor. Just an end user. End users don't have the right to request features, do they?

@pseudomonas
Copy link

We have the right to request; not to berate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: To assign
Development

No branches or pull requests

6 participants