Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Volume management #4059

Closed
3 tasks done
4164696f73 opened this issue Sep 19, 2023 · 6 comments
Closed
3 tasks done

[Feature Request]: Volume management #4059

4164696f73 opened this issue Sep 19, 2023 · 6 comments
Labels

Comments

@4164696f73
Copy link

Guidelines

  • I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
  • I have searched the documentation for information that matches the description of the feature request I want to file, without success.
  • This issue contains only one feature request.

Problem Description

Make it more advanced etc. Improvements similar to what Enhancer for Youtube offers.

Proposed Solution

  1. Option to reset volume to default after switching to another video.
  2. Separate volume adjustment for mouse and arrow keys. For example, I want to set "up arrow" to increase volume by 5%, but mouse wheel (scroll) to increase it by 1% (same for decreasing volume).
  3. Temporarily remember the volume settings of last video (not permanently, closing Freetube would forget that).

Alternatives Considered


Issue Labels

improvement to existing feature, new feature, new optional setting

Additional Information

Legends say I only remembered like half or less of what I wanted to suggest...

@absidue
Copy link
Member

absidue commented Sep 19, 2023

Number 3 is how FreeTube behaves today, the volume is remembered across videos in the same window.

@toby63
Copy link

toby63 commented Oct 6, 2023

@4164696f73 For always using Option 1 I wrote the following patch:

--- ft-video-player.js	2023-05-01 21:31:18.502416525 +0200
+++ new/ft-video-player.js	2023-05-08 23:11:29.156292693 +0200
@@ -753,7 +753,8 @@
         sessionStorage.setItem('muted', muted)
       } else {
         // If volume isn't muted by dragging the slider, muted and volume values are carried over to next video.
-        const volume = this.player.volume()
+        // const volume = this.player.volume()
+        const volume = parseFloat(sessionStorage.getItem('defaultVolume'))
         const muted = this.player.muted()
         sessionStorage.setItem('volume', volume)
         sessionStorage.setItem('muted', muted)

@Wehrmachtserdbeere
Copy link

Number 3 is how FreeTube behaves today, the volume is remembered across videos in the same window.

It doesn't. Every time I have to reload the app (which is very often), it resets the volume to full.

@absidue
Copy link
Member

absidue commented Oct 23, 2023

Not sure why you are surprised about something resetting when you reload, that clears all temporary data including the saved volume. We have never recommended reloading FreeTube, why exactly are you doing it?
I have never in two years of using and working on FreeTube had to reload.

@Wehrmachtserdbeere
Copy link

Because every time I lose connection, the client grinds the currently playing video to a halt. So it's just easier to press "CTRL + R" than to copy the title, put it into the search bar, and going back to the same video, or to click on share, copy the URL, then paste that into the search bar. 3 User Interactions vs 1 User Interaction.

@efb4f5ff-1298-471a-8973-3d47447115dc

This discussion belongs in #2295

Duplicate of #2295

@github-actions github-actions bot added the U: duplicate This issue or pull request already exists label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants