Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Remember the Playlists "Sort By" selection between sessions #5008

Open
3 tasks done
profucius opened this issue Apr 23, 2024 · 14 comments
Open
3 tasks done
Labels

Comments

@profucius
Copy link

Guidelines

  • I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
  • I have searched the documentation for information that matches the description of the feature request I want to file, without success.
  • This issue contains only one feature request.

Problem Description

Currently, the Sort By dropdown selection box forgets the chosen selection between sessions (close Freetube and then launch again). It always defaults to "Recently Played". I want it to remember which choice was last selected between sessions.

Proposed Solution

Make it remember the last chosen selection.

You can implement this similarly to this: In the beta build 4242 (at least), within a playlist there is another "Sort By" dropdown selection box. This selection does remember the last chosen selection between sessions.

Alternatives Considered

No alternatives.

Issue Labels

improvement to existing feature

Additional Information

image

@profucius profucius added the enhancement New feature or request label Apr 23, 2024
@kommunarr
Copy link
Collaborator

Inviting discussion from other contributors, but I think this is a reasonable change. If someone changed that sort, they probably would want to keep it. This is especially relevant for #4594, where we wouldn't want the sort order of the inline playlists reverting if it was changed in a given session.

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Apr 23, 2024

The add to playlist window also has a sort by that works in the same way as the OP described. Should we also change that? Im not sure

Edit: im fine with the change for this page

@kommunarr
Copy link
Collaborator

kommunarr commented Apr 23, 2024

The add to playlist window also has a sort by that works in the same way as the OP described. Should we also change that?

I honestly think if we make the Playlist search UX more compact, we do not need either the Add Video to Playlist search bar or sort dropdown. So I think it's fine that we keep it the same for now. That, and that mode is far more transient than this, I would say.

@ArthurKun21
Copy link

Would it also be possible to also remember the sorting of it when you played a playlist. Like when you sort latest added first when you play the playlist it would also be the same

@kommunarr
Copy link
Collaborator

Would it also be possible to also remember the sorting of it when you played a playlist. Like when you sort latest added first when you play the playlist it would also be the same

If you're talking about having the user playlist sort order being reflected in the box on the /Watch route, this is a separate issue that I have a soon-to-be-released PR for.

@susansli
Copy link

susansli commented May 7, 2024

Hi! I would like to do this issue.

@keerthana054
Copy link

Hi! Can I work on this issue.

@susansli
Copy link

@keerthana054 I was planning to do it soon now that I have some downtime.

@keerthana054
Copy link

@keerthana054 I was planning to do it soon now that I have some downtime.

ok. kindly let me know, if I can contribute to this work in any way. Thank you

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented May 31, 2024

@keerthana054 I was planning to do it soon now that I have some downtime.

@susansli could you be more specific on what you mean with soon? It would be nice to include this into the upcoming release :)

@susansli
Copy link

Hi, someone can take over for me. I had something come up - appreciate the opportunity though!

@efb4f5ff-1298-471a-8973-3d47447115dc

@keerthana054 would you like to take this?

@vF360
Copy link

vF360 commented Aug 24, 2024

I need this! It's so annoying seeing my playlists move around after I've finished watching a video.

@profucius
Copy link
Author

I'd just like to touch base on this ticket to keep it alive. Anyone taken a look at it yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: To assign
Development

No branches or pull requests

7 participants