Build with `openconnect` fails with `dtls.c:154:24: error: dereferencing pointer to incomplete type 'SSL_SESSION {aka struct ssl_session_st}'`. #976

dreirund · 2024-04-19T09:26:11Z

dreirund
Apr 19, 2024

When I want to build "Freetz-NG" with openconnect, build fails with dtls.c:154:24: error: dereferencing pointer to incomplete type 'SSL_SESSION {aka struct ssl_session_st}':

make:

[...]
cmd() { PATH="/home/<censored>/download/Router/AVM/FritzBox_7362SL/firmware/freetz-ng/freetz-ng/toolchain/build/mips_gcc-5.5.0_uClibc-1.0.14-nptl_kernel-3.10/mips-linux-uclibc/bin:/home/<censored>/download/Router/AVM/FritzBox_7362SL/firmware/freetz-ng/freetz-ng/toolchain/build/mips_gcc-5.5.0/mips-unknown-linux-gnu/bin:/home/<censored>/download/Router/AVM/FritzBox_7362SL/firmware/freetz-ng/freetz-ng/toolchain/build/mips_gcc-5.5.0_uClibc-1.0.14-nptl_kernel-3.10/mips-linux-uclibc/bin-ccache:/home/<censored>/download/Router/AVM/FritzBox_7362SL/firmware/freetz-ng/freetz-ng/toolchain/build/mips_gcc-5.5.0/mips-unknown-linux-gnu/bin-ccache:/home/<censored>/download/Router/AVM/FritzBox_7362SL/firmware/freetz-ng/freetz-ng/tools/path:/usr/local/bin:/usr/bin:/bin:/usr/local/sbin:/opt/android-sdk/emulator:/opt/android-sdk/cmdline-tools/latest/bin:/opt/android-sdk/platform-tools:/usr/lib/jvm/default/bin:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl:/usr/local/bin:/usr/local/sbin:/home/<censored>/bin:/usr/sbin" LD_RUN_PATH="/usr/lib/freetz" FREETZ_LIBRARY_DIR="/usr/lib/freetz" make -j1  "$@"  || { [ "2" = "0" ] && echo && cat .build.log 2>/dev/null; kill $$ 2>/dev/null || kill $$$$ 2>/dev/null; printf "\n\\033[33m%s\\033[m\n" "ERROR: Build failed.";  exit 1; } }; 			mkdir -p source; [ -n "" ] && step="/" || step=""; [ -n "" ] && step="$step/"; case "" in BIN)	echo -n "package/"         >source/.echo_item_tmp ;; LIB)	echo -n "library/"         >source/.echo_item_tmp ;; HTL)	echo -n "tools/"           >source/.echo_item_tmp ;; KTC)	echo -n "toolchain/kernel$step" >source/.echo_item_tmp ;; TTC)	echo -n "toolchain/target$step" >source/.echo_item_tmp ;; KRN)	echo -n "kernel"                 >source/.echo_item_tmp ;; esac; if ! diff -q source/.echo_item_tmp source/.echo_item_new >/dev/null 2>&1 || [ ! -e source/.echo_item_1st ]; then 	if [ -e source/.echo_item_end -a -e source/.echo_item_new -a -e source/.echo_item_1st ]; then echo -e "\e[48;5;26mdone\e[49m."; rm -f source/.echo_item_end source/.echo_item_1st; fi; [ -s source/.echo_item_tmp ] && cat source/.echo_item_tmp > source/.echo_item_new 2>/dev/null; [ -s source/.echo_item_new ] || cat source/.echo_item_old > source/.echo_item_new 2>/dev/null; if [ -s "source/.echo_item_new" ]; then echo -ne "\e[48;5;90m---> "; cat source/.echo_item_new 2>/dev/null | tee source/.echo_item_old; echo -ne "\e[49m ... "; [ "2" != "0" ] && echo; touch source/.echo_item_end; touch source/.echo_item_1st; fi; fi; echo -ne "\e[48;5;56mbuilding\e[49m ... "; cmd -C source/target-mips_gcc-5.5.0_uClibc-1.0.14-nptl_kernel-3.10/openconnect-7.04 openconnect \
	LDFLAGS=""
building ...   CC       openconnect-xml.o
  CC       openconnect-main.o
New version: v7.04-unknown
  CC       libopenconnect_la-version.lo
  CC       libopenconnect_la-ssl.lo
  CC       libopenconnect_la-http.lo
  CC       libopenconnect_la-auth.lo
  CC       libopenconnect_la-library.lo
library.c: In function 'openconnect_has_tss_blob_support':
library.c:550:2: warning: 'ENGINE_load_builtin_engines' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
  ENGINE_load_builtin_engines();
  ^
In file included from library.c:543:0:
/home/<censored>/download/Router/AVM/FritzBox_7362SL/firmware/freetz-ng/freetz-ng/toolchain/build/mips_gcc-5.5.0_uClibc-1.0.14-nptl_kernel-3.10/mips-linux-uclibc/include/openssl/engine.h:358:28: note: declared here
 OSSL_DEPRECATEDIN_3_0 void ENGINE_load_builtin_engines(void);
                            ^
library.c:552:2: warning: 'ENGINE_by_id' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
  e = ENGINE_by_id("tpm");
  ^
In file included from library.c:543:0:
/home/<censored>/download/Router/AVM/FritzBox_7362SL/firmware/freetz-ng/freetz-ng/toolchain/build/mips_gcc-5.5.0_uClibc-1.0.14-nptl_kernel-3.10/mips-linux-uclibc/include/openssl/engine.h:336:31: note: declared here
 OSSL_DEPRECATEDIN_3_0 ENGINE *ENGINE_by_id(const char *id);
                               ^
library.c:554:3: warning: 'ENGINE_free' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
   ENGINE_free(e);
   ^
In file included from library.c:543:0:
/home/<censored>/download/Router/AVM/FritzBox_7362SL/firmware/freetz-ng/freetz-ng/toolchain/build/mips_gcc-5.5.0_uClibc-1.0.14-nptl_kernel-3.10/mips-linux-uclibc/include/openssl/engine.h:493:27: note: declared here
 OSSL_DEPRECATEDIN_3_0 int ENGINE_free(ENGINE *e);
                           ^
  CC       libopenconnect_la-compat.lo
  CC       libopenconnect_la-dtls.lo
dtls.c: In function 'start_dtls_handshake':
dtls.c:121:3: warning: 'DTLSv1_client_method' is deprecated: Since OpenSSL 1.1.0 [-Wdeprecated-declarations]
   dtls_method = DTLSv1_client_method();
   ^
In file included from openconnect-internal.h:45:0,
                 from dtls.c:29:
/home/<censored>/download/Router/AVM/FritzBox_7362SL/firmware/freetz-ng/freetz-ng/toolchain/build/mips_gcc-5.5.0_uClibc-1.0.14-nptl_kernel-3.10/mips-linux-uclibc/include/openssl/ssl.h:2041:50: note: declared here
 OSSL_DEPRECATEDIN_1_1_0 __owur const SSL_METHOD *DTLSv1_client_method(void);
                                                  ^
dtls.c:154:24: error: dereferencing pointer to incomplete type 'SSL_SESSION {aka struct ssl_session_st}'
   vpninfo->dtls_session->ssl_version = 0x0100; /* DTLS1_BAD_VER */
                        ^
dtls.c:180:14: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
  dtls_cipher = sk_SSL_CIPHER_value(ciphers, 0);
              ^
dtls.c:184:48: error: dereferencing pointer to incomplete type 'SSL_CIPHER {aka struct ssl_cipher_st}'
  vpninfo->dtls_session->cipher_id = dtls_cipher->id;
                                                ^
make[2]: *** [Makefile:896: libopenconnect_la-dtls.lo] Error 1
make[1]: *** [make/pkgs/openconnect/openconnect.mk:23: source/target-mips_gcc-5.5.0_uClibc-1.0.14-nptl_kernel-3.10/openconnect-7.04/openconnect] Terminated
make: *** [Makefile:47: envira] Terminated

(I have censored my local user name.)

grep OPENCONNECT .config:

FREETZ_PACKAGE_OPENCONNECT=y
# FREETZ_PACKAGE_OPENCONNECT_STATIC is not set

Disabling FREETZ_PACKAGE_OPENCONNECT makes build of "Freetz-NG" continuing.

Freetz-NG version: Freetz-NG 23565M-f2a453e28 master 2024-04-18,
Attached: .config.

Regards!

fda77 · 2024-04-19T12:09:32Z

fda77
Apr 19, 2024
Collaborator

same -> openssl 3 ](deprecated: Since OpenSSL 3.0)

1 reply

dreirund Apr 19, 2024
Author

openssl 3 ](deprecated: Since OpenSSL 3.0)

On my distribution, Arch Linux, there is an openconnect (version 9.12), that is built against vpnc (version 0.5.3) which in turn is built against OpenSSL 3.x.

So it seems there is indeed an openconnect variant that is working with OpenSSL.

"Freetz-NG" still uses openconnect version 7.04, maybe an update is needed?

In the meantime it might be advisable to disable openconnect build if no
matching OpenSSL version is available in "Freetz-NG".

fda77 · 2024-04-20T23:15:50Z

fda77
Apr 20, 2024
Collaborator

Just put the openssl3 patches into https://github.com/Freetz-NG/freetz-ng/tree/master/make/pkgs/vpnc/patches/ and "make vpnc-recompile" to check if the patch can be applied and compiled

openconnect should be updated (if possible with yor old device/kernel/libc/...), there where no changes since years in freetz: https://github.com/Freetz-NG/freetz-ng/tree/master/make/pkgs/openconnect
after changes: "make openconnect-recompile"

2 replies

dreirund Apr 21, 2024
Author

Just put the openssl3 patches
into https://github.com/Freetz-NG/freetz-ng/tree/master/make/pkgs/vpnc/patches/ and
"make vpnc-recompile" to check if the patch can be applied and
compiled

I am going to test and report back.

dreirund Apr 21, 2024
Author

Just put the openssl3 patches

I now wanted to try, but I do not know which openssl3-patches you mean.

vpnc and openconnect on Arch Linux both download the upstream release without any additional patches. So it seems that upstream itself supports openssl3 with their up to date version.

fda77 · 2024-04-21T18:27:27Z

fda77
Apr 21, 2024
Collaborator

The latest version of vpnc is 0.5.3 from Wed Nov 19 21:29:22 CET 2008, i'm sure there was no openssl3 https://www.unix-ag.uni-kl.de/~massar/vpnc/

2 replies

dreirund Apr 22, 2024
Author

Indeed it is not vpnc that fails to build, but openconnect itself (make vpnc-recompile without any issues, the issue is with openconnect, which in upstream is newer (9.12) than what I encountered in Freetz-NG (7.04)).

fda77 Apr 22, 2024
Collaborator

That is very old and many things could have changed, maybe all

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build with `openconnect` fails with `dtls.c:154:24: error: dereferencing pointer to incomplete type 'SSL_SESSION {aka struct ssl_session_st}'`. #976

{{title}}

Replies: 3 comments 5 replies

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

Select a reply

Build with openconnect fails with dtls.c:154:24: error: dereferencing pointer to incomplete type 'SSL_SESSION {aka struct ssl_session_st}'. #976

dreirund Apr 19, 2024

Replies: 3 comments · 5 replies

fda77 Apr 19, 2024 Collaborator

dreirund Apr 19, 2024 Author

fda77 Apr 20, 2024 Collaborator

dreirund Apr 21, 2024 Author

dreirund Apr 21, 2024 Author

fda77 Apr 21, 2024 Collaborator

dreirund Apr 22, 2024 Author

fda77 Apr 22, 2024 Collaborator

Build with `openconnect` fails with `dtls.c:154:24: error: dereferencing pointer to incomplete type 'SSL_SESSION {aka struct ssl_session_st}'`. #976

dreirund
Apr 19, 2024

Replies: 3 comments 5 replies

fda77
Apr 19, 2024
Collaborator

dreirund Apr 19, 2024
Author

fda77
Apr 20, 2024
Collaborator

dreirund Apr 21, 2024
Author

dreirund Apr 21, 2024
Author

fda77
Apr 21, 2024
Collaborator

dreirund Apr 22, 2024
Author

fda77 Apr 22, 2024
Collaborator