Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux Mint Dark Theme Verification Broken #18

Open
EchoEllet opened this issue Jul 5, 2024 · 0 comments
Open

Linux Mint Dark Theme Verification Broken #18

EchoEllet opened this issue Jul 5, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@EchoEllet
Copy link
Collaborator

Currently, the check will execute the following command:

gsettings get org.cinnamon.theme name

Which will depend on the selected Desktop Theme In the Mint Desktop environment.

Linux Mint Select Desktop Theme

image

Since I have not found a simple way to check if the desktop theme is in dark mode in KDE or Mint
without installing extra dependencies either on the system with a package (e.g., apt, dnf)

I was only able to retrieve the current system theme name by either reading a file or executing a command, the script will retrieve the theme name and see if it has dark in it (regardless of case) or if it's one of the known dark themes:

// List of known themes
val knownDarkThemeNames =
    listOf(
        "Mint-Y-Dark",
        "Mint-Y-Dark-Aqua",
        "Mint-Y-Dark-Blue",
        "Mint-Y-Dark-Brown",
        "Mint-Y-Dark-Grey",
        "Mint-Y-Dark-Orange",
        "Mint-Y-Dark-Pink",
        "Mint-Y-Dark-Purple",
        "Mint-Y-Dark-Red",
        "Mint-Y-Dark-Sand",
        "Cinnamon",
        "Linux Mint",
    )

This currently will have two issues:

  1. If the installed theme is third-party and doesn't have dark in the name, the script won't be able to identify it as a dark theme, the same issue occurs on KDE Plasma.
  2. The current command above retrieves the Desktop Theme which might not be the same as the list above, Mint allows the user to select a theme for the Window borders, Icons, Controls, Mouse Painter, Desktop.
@EchoEllet EchoEllet added bug Something isn't working enhancement New feature or request and removed enhancement New feature or request labels Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant