Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Waning about New Context API #73

Open
ovaldi opened this issue Jul 3, 2019 · 1 comment
Open

Waning about New Context API #73

ovaldi opened this issue Jul 3, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@ovaldi
Copy link
Contributor

ovaldi commented Jul 3, 2019 •
edited
Loading

After I upgrade React & React-DOM to 16.8.6，I see this warning:

image

So, the ThemeProvider should to use New Context API, right?

image
@markusguenther
Copy link
Member

Thanks @ovaldi for reporting this.
Can not promise to tackle that soonish. But if you want you can give it a try 🎉

@markusguenther markusguenther added the bug Something isn't working label Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markusguenther @ovaldi