Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong content and count within the compare with deleted products #74

Open
sd-lueckel opened this issue Jun 26, 2024 · 1 comment
Open
Labels
kind/enhancement New feature or request

Comments

@sd-lueckel
Copy link

PHP Version

8.2

Shopware Version

6.5.8.11

Plugin Version

2.0.0

Actual behaviour

If products are added to the compare which are not available anymore, than the plugin will show a wrong compare number and only shows the remaining available products within the compare

image image

Expected behaviour

If a product is not available anymore, the product should not be shown in the compare anymore

Steps to Reproduce?

  • Create 3 products
  • Add all to compare
  • Delete 1 product

I think the problem is, that everything is stored in a local storage but there is never a check if the stored products are available anymore

@sd-lueckel sd-lueckel added the kind/bug Something isn't working label Jun 26, 2024
@tinect tinect added kind/enhancement New feature or request and removed kind/bug Something isn't working labels Jul 4, 2024
@tinect
Copy link
Member

tinect commented Jul 4, 2024

As discussed at #73 there will be no check on every page view.

You're welcome to create a check when viewing the compare page which also updates the local storage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants