Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renew SPLIT_TOKEN #759

Open
SSFGizmo opened this issue Apr 3, 2024 · 4 comments
Open

Renew SPLIT_TOKEN #759

SSFGizmo opened this issue Apr 3, 2024 · 4 comments

Comments

@SSFGizmo
Copy link

SSFGizmo commented Apr 3, 2024

Can SPLIT_TOKEN be renewed in // EXTENSION BUILDER DEFAULTS END TOKEN ..., because the PHP-CS-Fixer with the default configuration constantly changes it to //# EXTENSION BUILDER DEFAULTS END TOKEN ...?

@DavidBruchmann
Copy link
Contributor

DavidBruchmann commented Apr 3, 2024

Actually it'S defined differently, but // is probably better than ##

const SPLIT_TOKEN = '## EXTENSION BUILDER DEFAULTS END TOKEN - Everything BEFORE this line is overwritten with the defaults of the extension builder';

Problem might be in yaml files perhaps, I don't know if comments are possible there with //

Whats you suggestion and reasoning?

@DavidBruchmann
Copy link
Contributor

In PHP files some comments starting with # might be mistaken as annotation and lead to errors therefore. It depends on the context though.

@DavidBruchmann
Copy link
Contributor

@PKuhlmay you think we can just change the token?
Or we need to take care about compatibility to former created extensions somehow?
I think the token could be used in yaml files too, is this compatible?

@PKuhlmay
Copy link
Collaborator

PKuhlmay commented Apr 4, 2024

I don't know, honestly. We could change it and then test it with old extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants