-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDR not detected by Elden Ring #1246
Comments
With some further testing, trying different builds and different settings do not seem to fix it. I tried enabling all of the different config options like protonify, still no luck. Proton 9.0-2 -> gamescope -> HDR works Proton Experimental -> gamescope -> HDR works GE-Proton9-11 -> gamescope -> HDR works proton-ge-custom (AUR) -> gamescope -> HDR works proton-tkg (Valve Exp Bleeding Edge) -> gamescope -> HDR works proton-tkg (Wine Master) -> gamescope -> HDR greyed out in settings |
It's not expected to work on upstream bases so I don't see anything abnormal here. Works on valve trees as it should (outside of winewayland which is incomplete and broken). |
Oh okay, I just assumed enabling "protonify" (or one of the other config options) would pull in the patches to sort of convert upstream wine to match Valve's wine.
It does actually work perfectly in Divinity Original Sin 2 and Witcher 3, I haven't had any problems with it. Elden Ring also works perfectly minus the HDR detection, but since that's also not working with gamescope I'm just assuming it's unrelated to the wayland driver. I did find this pull request from about a year ago ValveSoftware/Proton#7048 So it does seem like Elden Ring (and Sekiro) in particular have always been finicky with HDR. But this was never merged so it must have gotten fixed some other way. If this is expected behavior feel free to close the issue, I don't want to waste your time. I was just hoping I could get it working because the game is noticeably smoother with the wayland driver compared to gamescope. And it seems like it should be possible with the right environment variable and/or patch. |
It works on my machine, albeit on Nvidia GPU, both with native wayland and gamescope. If I can somehow help debug, feel free to ping. |
I am about 95% sure I have narrowed the issue down to AMD AGS so I need to test some of the related patches, just haven't had time yet. Looks like it has caused a lot of HDR-detection issues on the OLED Steam Deck in the past for various games. Nvidia uses the NVAPI instead so that's probably why it works fine. But actually this is off topic to this issue but I do have a friend with a 2080 Ti who can't seem to launch proton-tkg at all, and gamescope crashes for them in all games regardless of proton version. What does your setup look like and what launch options are you using? I would love to get HDR working for him. |
Right after I commented I thought of something and tried it out. I manually copied |
sed -i 's/distro=""/distro="archlinux"/' proton-tkg.cfg
sed -i 's/uninstaller="false"/uninstaller="true"/' proton-tkg.cfg
sed -i 's/autoinstall="false"/autoinstall="true"/' proton-tkg.cfg
sed -i 's/LOCAL_PRESET=""/LOCAL_PRESET="none"/' proton-tkg.cfg
sed -i 's/build_gstreamer="false"/build_gstreamer="true"/' proton-tkg.cfg
sed -i 's/lib32_gstreamer="false"/lib32_gstreamer="true"/' proton-tkg.cfg
sed -i 's/wayland_driver="false"/wayland_driver="true"/' proton-tkg.cfg
sed -i 's/use_esync="true"/use_esync="false"/' proton-tkg.cfg
sed -i 's/use_fsync="true"/use_fsync="false"/' proton-tkg.cfg
sed -i 's/use_ntsync="false"/use_ntsync="true"/' proton-tkg.cfg
COLORFGBG=15;0
COLORTERM=truecolor
DISPLAY=:1
ELECTRON_OZONE_PLATFORM_HINT=wayland
GBM_BACKEND=nvidia-drm
KDE_APPLICATIONS_AS_SCOPE=1
KDE_FULL_SESSION=true
KWIN_DRM_DEVICES=/dev/dri/card0:/dev/dri/by-path/pci-0000:00:02.0-card
LANG=en_US.utf8
PLASMA_USE_QT_SCALING=1
QT_AUTO_SCREEN_SCALE_FACTOR=0
QT_WAYLAND_RECONNECT=1
SHELL=/bin/zsh
SHELL_SESSION_ID=634a7777bab648a3b00f9577b0853839
SHLVL=1
TERM=xterm-256color
USER=pew
WAYLAND_DISPLAY=wayland-0
WINEDLLOVERRIDES=winemenubuilder.exe=d
XAUTHORITY=/run/user/1000/xauth_InSkci
XDG_ACTIVATION_TOKEN=kwin-2
XDG_CONFIG_DIRS=/home/pew/.config/kdedefaults:/etc/xdg
XDG_CURRENT_DESKTOP=KDE
XDG_DATA_DIRS=/home/pew/.local/share/flatpak/exports/share:/var/lib/flatpak/exports/share:/usr/local/share:/usr/share
XDG_MENU_PREFIX=plasma-
XDG_RUNTIME_DIR=/run/user/1000
XDG_SEAT=seat0
XDG_SESSION_CLASS=user
XDG_SESSION_DESKTOP=plasma
XDG_SESSION_ID=2
XDG_SESSION_TYPE=wayland
XDG_VTNR=1
__GLX_VENDOR_LIBRARY_NAME=nvidia |
Thank you so much, I made a build with your exact settings and then taking these three environment variables: Without those options the games would crash and/or freeze after a few seconds but with them it works. However the performance took a roughly 20% hit until also switching from 555 to the 560 beta for whatever reason. But with those three things combined it's working perfectly in all the games we've tested. |
|
In Elden Ring HDR works perfectly with Proton Experimental and
proton-ge-custom
, but it does not work with proton-tkg.Using this:
gamescope -f -W 3840 -H 2160 --hdr-enabled -- python er-patcher --all --rate 120 -- %command%
The option is greyed out in the menu so Elden Ring is not detecting that HDR is available.
I tried a few different versions from the GitHub CI and my own build and it did not work on any of them. Is there a particular patch or config option that's needed?
I should also note that HDR works fine with Divinity Original Sin 2 and The Witcher 3, even without gamescope, so this is something that seems to be tripping up Elden Ring in particular.
Arch Linux
Ryzen 9 7950X + RX 7900XTX
Kernel 6.10.4-zen2-1-zen
Mesa 24.1.6
KDE Plasma 6.1.4
The text was updated successfully, but these errors were encountered: