Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't write out byte order mark #135

Open
BradBarnich opened this issue Dec 10, 2015 · 0 comments
Open

Doesn't write out byte order mark #135

BradBarnich opened this issue Dec 10, 2015 · 0 comments

Comments

@BradBarnich
Copy link

Modifying a project removes the BOM. It's not a huge deal, just causes churn. From what I can tell, Visual Studio always writes a BOM to csproj files.

I think the issue is in here: https://github.com/DarthFubuMVC/FubuCsProjFile/blob/master/src/FubuCsProjFile/MSBuild/MSBuildProject.cs#L535

It gets the encoding by name, but to explicitly write out the BOM I think the encoding needs to be constructed this way new UTF8Encoding(true)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant