Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open source this repo #37

Closed
andistuder opened this issue Jul 28, 2015 · 12 comments
Closed

open source this repo #37

andistuder opened this issue Jul 28, 2015 · 12 comments

Comments

@andistuder
Copy link

I think this is a good candidate for a open sourcing.

Needs updating of licence.

@andistuder
Copy link
Author

@sgerrand
Copy link
Contributor

I think this is a good candidate for a open sourcing.

@andistuder: What makes it a good candidate? I think it's good to articulate the reasons - this helps significantly with expediting the process.

Personally, I'd rather wait until after we've used it ourselves successfully and are happy with the way the code.

@dalizard
Copy link
Contributor

I agree with @andistuder but with @sgerrand as well 😸 I think we should give it some time for production testing and polishing.

@andistuder
Copy link
Author

@sgerrand IMO, in general good candidates solve something that other people may need to solve also; without giving away trade secrets. For Loga, our tool to standardise and aggregate logs both is the case.

To the timing: personally I would prefer to have repos public from the start as visibility can have positive impact on how we write code. Plus, making an existing project public is often a bit of a hurdle that is then never taken.

The 0.x version should indicate to users that the project is in pre-production state.

@andistuder
Copy link
Author

@whamilton42 @timstott @RafaelPC @sgerrand given we are now in v1.x, maybe now the time has come to open source this gem?

@bliof
Copy link
Contributor

bliof commented Aug 29, 2016

👍 for opening the gem, but let's finish https://github.com/FundingCircle/loga/milestone/2 because at the moment it is a bit unusable (we all use Rails.logger.info and there is no easy way to specify a context).

@fernandezj
Copy link

fernandezj commented Sep 14, 2016

All,
happy to authorise opening this gem. Only two comments:

  • confirmation from Mark (security) about any requirements we could not be covering (just precaution, not assumption from me)
  • review open issues
  • write down wiki

@timstott
Copy link
Contributor

timstott commented Sep 14, 2016

We've agreed with @fernandezj to disable the wiki in favour of keeping the README.
I'm working on adding a CHANGELOG.

I think @sgerrand has reviewed the open issues/PRs

Tomorrow I will spend time with @mcsche on the security aspect 🎉

@mcsche
Copy link

mcsche commented Sep 14, 2016

@timstott @mcsche is at a conference and will return next Monday.

@0mega
Copy link

0mega commented Sep 15, 2016

Should we remove the ticket number from the PR title?

@sgerrand
Copy link
Contributor

@0mega: ✨

@timstott
Copy link
Contributor

🎉 Introducing Loga, Open sourced since 2016-11-17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants