From edfaf85f38ad6ed140960c2d34d6053b240e3f3a Mon Sep 17 00:00:00 2001 From: EliteMasterEric Date: Tue, 12 Mar 2024 23:23:25 -0400 Subject: [PATCH] Fix a crash when flickering in onComplete --- flixel/effects/FlxFlicker.hx | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/flixel/effects/FlxFlicker.hx b/flixel/effects/FlxFlicker.hx index 754d2aa2af..2baf758d52 100644 --- a/flixel/effects/FlxFlicker.hx +++ b/flixel/effects/FlxFlicker.hx @@ -182,7 +182,12 @@ class FlxFlicker implements IFlxDestroyable { completionCallback(this); } - release(); + + // NOTE: Calling `flicker` in the completion callback will call release() on this object before reinstantiating it. + // If that happens, we don't want to call release() again! So we check if the flicker is still done before releasing. + if (this.timer == Timer) { + release(); + } } }