Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specific exception catching #54

Open
achilleas-k opened this issue Sep 11, 2019 · 0 comments
Open

Specific exception catching #54

achilleas-k opened this issue Sep 11, 2019 · 0 comments

Comments

@achilleas-k
Copy link
Member

A lot of functions are wrapped in try .. except blocks with a catch-all Exception handler. In some cases, the block is doing things that aren't likely to cause exceptions (like appending items to a list). We should have more specific exception handlers and only have them where necessary.
achilleas-k added a commit that referenced this issue Sep 11, 2019
@achilleas-k
Major codestyle fixes and cleanup
4d68fd4 
- Names: camelCase to snake_case for all function, argument, and
variable names.
- Prefix functions with the name/type of the service they relate to:
e.g., gin_ensure_token and drone_ensure_secrets.
- Horizontal function signatures (instead of vertically stacking args).
- Removed small one-use functions that were creating single-key
dictionaries and replaced with literals.
- Renamed annexFiles to input_files and backPushFiles to output_files
- Cleared out some catch-all exception handling that seemed unnecessary.
This needs more work since there's a lot of catch-all exception blocks
that need revising.  See issue #54.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@achilleas-k