Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiTag intersection object #411

Open
achilleas-k opened this issue Jul 26, 2019 · 6 comments
Open

MultiTag intersection object #411

achilleas-k opened this issue Jul 26, 2019 · 6 comments

Comments

@achilleas-k
Copy link
Member

It came up in a discussion that intersecting MultiTags might be a useful feature. This could be a method that takes a list of MultiTags (or their names) and returns a new type (MultiTagView? similar to how a DataView is a sliced view of a DataArray) that has positions and extents that represent the intersection of the provided MTs. Similarly, the references of this MultiTagView would be the DataArrays that are referred to by all provided MultiTags.

@gicmo
Copy link
Member

gicmo commented Jul 26, 2019

Would that be a transient object or something that you would want to store in the file?

@jgrewe
Copy link
Member

jgrewe commented Jul 26, 2019

I guess this information should be stored in the file. much like a group with some more info.

@achilleas-k
Copy link
Member Author

I was thinking transient, which is why I mentioned the DataView.

@refactoriel
Copy link

Since this issue is still open I wanted to say that a MultiTag intersection object would be really useful for me.
For example if I wanted to get all spikes (first MultiTag) that occur around a specific behavioural event (second MultiTag) in trials of a certain condition (third MultiTag).

@achilleas-k
Copy link
Member Author

There's an open Pull Request for this in the nixworks library: G-Node/nixworks#19

It needs a bit more testing and a deeper review, which is why it's been open for so long.

@refactoriel
Copy link

Thanks for the link, I had only checked this repo and couldn't find a branch/PR for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants