You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's not generally a slow process. There's a sorting going on in the method which is going to be removed soon (see NeuralEnsemble#545) and ignoring that, it's an O(N) function. Now, N is the number of signals first in a Group/Segment, and then for the whole Block, so all in all the entire reading process reads through the DataArrays twice. Since we're reading all the DataArrays in a Block anyway, we might as well collect them before descending into a Group and use a per-block collection/grouping of signals.
The text was updated successfully, but these errors were encountered:
The
_group_signals()
method is called once per Group/Segmentpython-neo/neo/io/nixio.py
Line 283 in 6bda789
and then a final time in each Block to find "groupless" signals:
python-neo/neo/io/nixio.py
Line 242 in 6bda789
It's not generally a slow process. There's a sorting going on in the method which is going to be removed soon (see NeuralEnsemble#545) and ignoring that, it's an O(N) function. Now, N is the number of signals first in a Group/Segment, and then for the whole Block, so all in all the entire reading process reads through the DataArrays twice. Since we're reading all the DataArrays in a Block anyway, we might as well collect them before descending into a Group and use a per-block collection/grouping of signals.
The text was updated successfully, but these errors were encountered: