Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce button states? #18

Open
GBKS opened this issue Jan 20, 2023 · 1 comment
Open

Introduce button states? #18

GBKS opened this issue Jan 20, 2023 · 1 comment
Assignees
Milestone

Comments

@GBKS
Copy link
Owner

GBKS commented Jan 20, 2023

We created a whole set of states (hover, active...) for buttons in the Bitcoin Core App (see in Figma here). Do we want to port those over to the UI Kit?

If so, is it maybe time to split the Button into several sub-components to make them easier to manage. We have lots of configurations (3 sizes, 3 styles, 5 states, 4 content variations = 180). There is complexity, the question is just where do we put it.

  • One massive Button component with lots of properties (as we have now)?
  • Multiple components (IconButton, TextButton, TextIconButton, IconTextButton) that are almost interchangeable?

My initial hunch is to keep components simple (fewer properties) so there's less hidden (less guessing) and less explanation (spec sheets) needed. But let's discuss.

A follow-up discussion would be to document the standard treatments for focus, hover... and which other components would need updating.

@GBKS GBKS added this to the February 2023 milestone Jan 31, 2023
@GBKS GBKS self-assigned this Mar 23, 2023
@GBKS GBKS pinned this issue Dec 19, 2023
@GBKS
Copy link
Owner Author

GBKS commented Dec 19, 2023

We solved this in the Bitcoin Core App and can just port it from there. Just need to be very careful not to break the 200-300 screen designs when changing over the button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant