Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set uses cloneVal #35

Open
qbolec opened this issue Oct 27, 2014 · 1 comment
Open

set uses cloneVal #35

qbolec opened this issue Oct 27, 2014 · 1 comment

Comments

@qbolec
Copy link

qbolec commented Oct 27, 2014

Is there a good reason for cloning parameters passed to Model.set?
This makes it quite difficult to assign native types like MediaStream without loosing their original behaviour.

@GCheung55
Copy link
Owner

That's a good question. I went I search for the answer by following the trail of commits but came up empty.

I don't remember the exact reason but it may be more flexible without cloning. Which means the dev is responsible for dereferencing arrays and objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants