diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml deleted file mode 100644 index d6318102..00000000 --- a/.github/workflows/release.yml +++ /dev/null @@ -1,28 +0,0 @@ -name: deploy burimi app - -on: - push: - branches: - - main - -jobs: - deploy: - runs-on: ubuntu-latest - steps: - - name: Checkout - uses: actions/checkout@v3 - - - name: Generate deployment package - run: zip -r ${{ github.sha }}.zip . -x "*.git*" node_modules - - - name: Deploy to EB - uses: einaregilsson/beanstalk-deploy@v20 - with: - aws_access_key: ${{secrets.AWS_ACCESS_KEY_ID}} - aws_secret_key: ${{secrets.AWS_SECRET_ACCESS_KEY}} - application_name: burimi-server - environment_name: Burimi-server-env - version_label: ${{ github.sha }} - version_description: ${{ github.event.head_commit.message }} - region: ap-northeast-2 - deployment_package: ${{ github.sha }}.zip diff --git a/src/apis/notice/controller.ts b/src/apis/notice/controller.ts index 851755c6..009145f4 100644 --- a/src/apis/notice/controller.ts +++ b/src/apis/notice/controller.ts @@ -6,7 +6,7 @@ router.get('/', async (req: Request, res: Response) => { try { const major = req.query.major as string; let notices; - if (major === undefined) { + if (major === 'undefined') { notices = await getSchoolNotices(); } else { notices = await getNotices(major);