Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bcrypt module #1650

Closed
dbauszus-glx opened this issue Oct 31, 2024 · 0 comments · Fixed by #1640
Closed

bcrypt module #1650

dbauszus-glx opened this issue Oct 31, 2024 · 0 comments · Fixed by #1640
Labels
Bug A genuine bug. There must be some form of error exception to work with. Code Issues related to the code structure and performance. Deprecated Features which are no longer supported and should eventually be removed. Security Ticket relates to either the authentication process, security headers, and or encryption.

Comments

@dbauszus-glx
Copy link
Member

Issues with deprecated NPM modules noted in #1443 are related to the unmaintained bcrypt module.

kelektiv/node.bcrypt.js#1038

There is a whole dev dependency tree of dprecated modules for the bcrypt module. The maintainer has not yet responded to messages in this regard in we should not depend on this.

We should not contribute to the 20000000+ weekly downloads for modules the likes of https://www.npmjs.com/package/are-we-there-yet with each deployed instance.

We do not require to build the bcrypt script which is available as JS native script here. https://github.com/dcodeIO/bcrypt.js/blob/master/dist/bcrypt.js

The bcrypt JS script can be added as utils module for our use case.

#1641 must be resolved first since the node-fetch module required by the cloudfront module is not included in the package but installed as a dev dependency for the bcrypt module.

@dbauszus-glx dbauszus-glx added Bug A genuine bug. There must be some form of error exception to work with. Code Issues related to the code structure and performance. Security Ticket relates to either the authentication process, security headers, and or encryption. labels Oct 31, 2024
@dbauszus-glx dbauszus-glx self-assigned this Oct 31, 2024
@dbauszus-glx dbauszus-glx added the Deprecated Features which are no longer supported and should eventually be removed. label Oct 31, 2024
@dbauszus-glx dbauszus-glx linked a pull request Oct 31, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A genuine bug. There must be some form of error exception to work with. Code Issues related to the code structure and performance. Deprecated Features which are no longer supported and should eventually be removed. Security Ticket relates to either the authentication process, security headers, and or encryption.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants