Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up aerosol-related fields in met_force_type?? #387

Open
gmao-rreichle opened this issue Apr 28, 2021 · 0 comments
Open

clean up aerosol-related fields in met_force_type?? #387

gmao-rreichle opened this issue Apr 28, 2021 · 0 comments
Assignees

Comments

@gmao-rreichle
Copy link
Contributor

The implementation of the dirty snow albedo (GOSWIM) in GEOSldas introduced 60 new forcing fields in met_force_type (DUDP001, DUDP002, etc).
It is unclear if the implementation works at this time. Chances are it does not because there's not a corresponding MPI type in LDAS_ensdrv_mpi.F90.
Also, the aerosol forcing fields are not considered in subroutine check_nodata_forcing().
It is unclear how much unneeded memory is allocated, and whether clean-up might be needed to free up this memory.
I am writing this up now because I noticed these issues during my recent clean-up of the met forcing code and wanted to make a note somewhere. No immediate action is necessary.
@weiyuan-jiang @biljanaorescanin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant