Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some logic in SU2G_GridCompMod #263

Open
pcolarco opened this issue Feb 2, 2024 · 1 comment · Fixed by #264
Open

Update some logic in SU2G_GridCompMod #263

pcolarco opened this issue Feb 2, 2024 · 1 comment · Fixed by #264
Assignees
Labels
0 diff structural Structural changes to repository that are zero-diff bugfix This is a bug fix

Comments

@pcolarco
Copy link
Contributor

pcolarco commented Feb 2, 2024

These are several enhancements captured here:

  • Sulfate surface area density calculation in SU_Compute_Diags was incorrectly being passed the effective radius used for settling along with the sigma width of the number distribution. Properly it should be passed the number median radius, also present in the RC file. Added a hook to read that field from the RC file ("particle_radius_number"), store in SU grid comp, and pass to SU_Compute_Diags. This change is zero-diff to the SU internal state. It changes value of export SO4AREA.
  • Add some protective logic around reading daily volcanic emission files. If filename does not exist model will write message to standard output and reset volcanic emissions to zero. This is zero difference result unless in a place where the files were not present.
  • Changed DMS concentration data holder from ExtData provided (SU_DMSO) to local copy (dmso_conc). This is relevant since if we run source tagged instances where we don't want DMS emissions we would zero out dmso_conc and that is what should be passed to DMSemission subroutine. This is zero diff except in that case.
@pcolarco pcolarco added 0 diff structural Structural changes to repository that are zero-diff bugfix This is a bug fix labels Feb 2, 2024
@pcolarco pcolarco self-assigned this Feb 2, 2024
@pcolarco
Copy link
Contributor Author

pcolarco commented Feb 2, 2024

changes committed to branch: feature/pcolarco/#263/SU2G_GridCompMod_logic

@pcolarco pcolarco linked a pull request Feb 2, 2024 that will close this issue
jrjoshi1 added a commit that referenced this issue Sep 23, 2024
…CompMod_logic

Feature/pcolarco/#263/su2g_gridcompmod logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff structural Structural changes to repository that are zero-diff bugfix This is a bug fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant