From 53fbeaa7c526ae6a2f21bade0e180adf58e02dd6 Mon Sep 17 00:00:00 2001 From: Matthew Thompson Date: Mon, 21 Mar 2022 14:47:15 -0400 Subject: [PATCH 1/3] Updates for Spack Support, Round 2 Due to insufficient grepping on my part, some remnants of the "not-canonical" CMake still remain. Apparently these were not necessary changes for Spack, but they are changes that unify the CMake style of GEOS to be more like "correct" CMake. In this go-around, it is mainly finding `INC_ESMF` which I apparently forgot to grep for last time (I was focused on NetCDF), and some non-canonical OpenMP calls. See https://github.com/GEOS-ESM/GEOSgcm/issues/387 for the meta-issue. --- ESMF/GOCART_GridComp/CMakeLists.txt | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/ESMF/GOCART_GridComp/CMakeLists.txt b/ESMF/GOCART_GridComp/CMakeLists.txt index ffd39452..cce3ec13 100644 --- a/ESMF/GOCART_GridComp/CMakeLists.txt +++ b/ESMF/GOCART_GridComp/CMakeLists.txt @@ -16,16 +16,15 @@ set (srcs set (resource_files GOCARTdata_AerRegistry.rc - ) + ) -install( FILES ${resource_files} +install( FILES ${resource_files} DESTINATION etc ) -set (dependencies Chem_Base Chem_Shared MAPL GMAO_mpeu) +set (dependencies Chem_Base Chem_Shared MAPL GMAO_mpeu esmf) esma_add_library (${this} SRCS ${srcs} SUBCOMPONENTS ${alldirs} - DEPENDENCIES ${dependencies} - INCLUDES ${INC_ESMF}) + DEPENDENCIES ${dependencies}) From 1f101dc41943144af8bd14e6ac2520f064739749 Mon Sep 17 00:00:00 2001 From: Matthew Thompson Date: Mon, 21 Mar 2022 14:54:07 -0400 Subject: [PATCH 2/3] Update components.yaml to match GEOSgcm v10.22.1 to pass CI --- components.yaml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/components.yaml b/components.yaml index c4a1c503..263629ed 100644 --- a/components.yaml +++ b/components.yaml @@ -5,13 +5,13 @@ GOCART: env: local: ./env@ remote: ../ESMA_env.git - tag: v3.11.0 + tag: v3.13.0 develop: main cmake: local: ./cmake@ remote: ../ESMA_cmake.git - tag: v3.10.0 + tag: v3.12.0 develop: develop ecbuild: @@ -22,17 +22,17 @@ ecbuild: HEMCO: local: ./ESMF/HEMCO_GridComp@ remote: ../HEMCO.git - branch: geos/v2.2.2 + branch: geos/v2.2.3 GMAO_Shared: local: ./ESMF/Shared/GMAO_Shared@ remote: ../GMAO_Shared.git - tag: v1.5.1 + tag: v1.5.3 sparse: ./config/GMAO_Shared.sparse develop: main MAPL: local: ./ESMF/Shared/MAPL@ remote: ../MAPL.git - tag: v2.18.0 + tag: v2.19.0 develop: develop From 37218216fae085860a19e3d6eee69017c41a99a8 Mon Sep 17 00:00:00 2001 From: Matthew Thompson Date: Mon, 21 Mar 2022 14:54:54 -0400 Subject: [PATCH 3/3] update changelog --- CHANGELOG.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 808a1246..70aa00d5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,9 +13,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - This matches the styles currently used in MAPL (2 space indents in CMake and yaml, 4 spaces for Python) ### Changed + - Updated the CircleCI to use circleci-tools 0.13.0 orb - Moves CI to use Baselibs 6.2.13 needed by MAPL development -- Update `components.yaml` to be in line with GEOSgcm v10.22.0 +- Update `components.yaml` to be in line with GEOSgcm v10.22.1 - Updates to support Spack - Changed the handling of state variable names in multiple instances of component (see Issue #93) - Major refactoring of Mie table class. (see Issue #96)