Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtData2G needs variant specification for update_offset #3064

Open
tclune opened this issue Oct 2, 2024 · 5 comments
Open

ExtData2G needs variant specification for update_offset #3064

tclune opened this issue Oct 2, 2024 · 5 comments
Assignees
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. ❗ High Priority This is a high priority PR 🎁 New Feature This is a new feature

Comments

@tclune
Copy link
Collaborator

tclune commented Oct 2, 2024

Currently ExtData2g supports:

update_offset: 900T

We need an option to instead specify a heartbeat offset like:

update_offset: heartbeat

(Extdata knows the heartbeat_dt.)

I'm thinking that we probably need to be able to specify multiples of heartbeat, so need a bit of exploration on best way to do this.

@tclune tclune added 🎁 New Feature This is a new feature 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. ❗ High Priority This is a high priority PR labels Oct 2, 2024
@tclune
Copy link
Collaborator Author

tclune commented Oct 2, 2024

Mentioning @amdasilva so he can monitor this issue.

@darianboggs
Copy link
Contributor

I'm reviewing this now.

@darianboggs
Copy link
Contributor

Initially, this will use the timestep of the ExtData grid component. In the future, it may use the model heartbeat.

@tclune
Copy link
Collaborator Author

tclune commented Oct 9, 2024

Initially, this will use the timestep of the ExtData grid component. In the future, it may use the model heartbeat.

Technically it is using the timestep of the ExtData clock. It just so happens that in MAPL2 all components share the same clock, and thus this clock ticks at the heartbeat. In MAPL3 each component has its own clock and this mechanism might become fragile if ExtData were to run less often than the heartbeat.

@bena-nasa
Copy link
Collaborator

Already had an issue open for this: #3000
Will close that issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. ❗ High Priority This is a high priority PR 🎁 New Feature This is a new feature
Projects
None yet
Development

No branches or pull requests

3 participants