Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAPL_GeomGet #3136

Open
pchakraborty opened this issue Oct 30, 2024 · 2 comments
Open

MAPL_GeomGet #3136

pchakraborty opened this issue Oct 30, 2024 · 2 comments
Labels
📈 MAPL3 MAPL 3 Related

Comments

@pchakraborty
Copy link
Collaborator

pchakraborty commented Oct 30, 2024

API to retrieve GEOM information

subroutine MAPL_GeomGet(geom, DE=...,localCellCount=..., globalCellCount=..., gridtype=...,  ...)

Output vars that are arrays should be allocatable so as not to force the user to query and then allocate and then call. GeomGet can call GridGet, LocStreamGet, etc. after determining the gridtype.
Needs an optional argument for DE as well.

@pchakraborty pchakraborty added the 📈 MAPL3 MAPL 3 Related label Oct 30, 2024
@bena-nasa
Copy link
Collaborator

We should also include the functionality provided by the old grid_get_interior in this call as other optional arguments perhaps, or just a separate refactoring of that routine. Also note that both these calls have the JM_World = 6*IM_WORLD convention for the cube. Probably something to debate if we want to keep this convention, but would have lots consequences

@tclune
Copy link
Collaborator

tclune commented Oct 30, 2024

I would so like to avoid the confusion of the "6x". And the confusion is really all my fault. As a purist I went about expunging the 6x from JM when I arrived, but even if I succeeded, it would just confuse everyone else.

Let's have a healthy debate on the topic at the MAPL meeting.

We certainly should not need to support the old CS "lat lon fake" in MAPL3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📈 MAPL3 MAPL 3 Related
Projects
None yet
Development

No branches or pull requests

3 participants