Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Field factory #3140

Open
tclune opened this issue Oct 31, 2024 · 0 comments
Open

Create Field factory #3140

tclune opened this issue Oct 31, 2024 · 0 comments
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related 🎁 New Feature This is a new feature

Comments

@tclune
Copy link
Collaborator

tclune commented Oct 31, 2024

The desire is to create an ESMF Field with all requisite metadata in a simple process.

Existing logic is in FieldSpec which is creating for states of gridcomps, but is problematic for Fields that are generated elsewhere (e.g., reallocation in couplers for time varying attributes, unit tests, etc.)
@tclune tclune added 🎁 New Feature This is a new feature 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related labels Oct 31, 2024
tclune added a commit that referenced this issue Nov 1, 2024
@tclune
Fixes #3140 - create field factory
ac1efc5 
This PR is the first of what will be a sequence of changes to wrap
ESMF_Field functionality.  The change introduces a new subdirectory
`field` and the following extensions:

- MAPL_FieldCreate
- MAPL_FieldReset
- MAPL_FieldInfo  (only internal info items for now)

The code compiles and passes rudimentary unit tests, but is not used
elsewher in MAPL.

Subsequent PRs will refactor other layers to use this as well as
relocate some all-but-redundant bits.
@tclune tclune mentioned this issue Nov 1, 2024
Closed
tclune added a commit that referenced this issue Nov 3, 2024
@tclune
Merge pull request #3143 from GEOS-ESM/feature/tclune/#3140-create-fi…
1373a4d 
…eld-factory

Feature/tclune/#3140 create field factory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related 🎁 New Feature This is a new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tclune