Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compare aed variables to field? #182

Open
hdugan opened this issue Oct 20, 2015 · 8 comments
Open

compare aed variables to field? #182

hdugan opened this issue Oct 20, 2015 · 8 comments
Labels

Comments

@hdugan
Copy link
Collaborator

hdugan commented Oct 20, 2015

Is there a way to calculate RMSE between field and modeled variables, as opposed to using a lakeAnalyzer function?
Example) Compare field data of oxygen to OXY_oxy?

@jordansread
Copy link
Member

I think this is worth adding, and my efforts here https://github.com/USGS-R/glmtools/pull/179/files should make it simpler.

But short answer, no this doesn't exist, but I think I can get something workable for you quickly

@jordansread
Copy link
Member

@hdugan are you converting your field Oxy data to use the same units as AED output?

@hdugan
Copy link
Collaborator Author

hdugan commented Oct 20, 2015

I've been using a homemade resample_to_field function that allows me to input a unit conversion

@jordansread
Copy link
Member

ok. It would be nice if resample_to_field wasn't so locked into water temps

@jordansread
Copy link
Member

as per convos in our last glmtools/GLMr workshop, it might be worth trying a function that adds the conversion as a new netcdf variable, so all of the _var functions would work.

@jordansread
Copy link
Member

with #205 we are most of the way there, but

compare_to_field(nc_file, field_file, nml_file, metric, as_value = FALSE, na.rm = TRUE, ...)

doesn't do anything generic with metric, instead it requires it to be a function that is similar to rLakeAnalyzer or a function in that package. It you give the name of the var as metric, it would be nice to have this just do a straight up pass through of the variable for as_value or RMSE in the units of the variable. The way it is now, there is water.temperature that spoofs a rLA function and just returns the data.frame. Would be nice to do this in the same way for anything that is a variable in the netcdf that also matches the field file.

@lawinslow
Copy link
Member

We could default metric to value or something like that that's just a straight pass-through? water.temperature is clearly weird.

@jordansread
Copy link
Member

I like using "value". It fits too w/ as_value too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants