Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure that time_steps (and all other parameters) are handled consistently between the simulation functions #10

Open
baurse opened this issue Feb 8, 2022 · 0 comments
Open

Make sure that time_steps (and all other parameters) are handled consistently between the simulation functions #10

baurse opened this issue Feb 8, 2022 · 0 comments

Comments

@baurse
Copy link
Contributor

baurse commented Feb 8, 2022

The meaning of the "time_steps" parameter is slightly different for the RK4-based simulation functions compared to the ETDRK4 based KS simulation: For the former, time_steps=1 only returns the initial condition, while time_steps=1 returns the first simulation step for the KS simulation!

This is an unnecessary stumbling block and should be standardized, probably to the former's behavior.
Intuition: time_steps = length of output, including the initial condition.
DuncDennis added a commit to DuncDennis/rescomp that referenced this issue Feb 11, 2022
@DuncDennis
Changed the meaning of the time_steps in the KS Simulations
85656e5 
time_steps = output_length and first-entry= initial condition.
See rescomp issue GLSRC#10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@baurse