Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

g_ScreenProbes_OverrideTileBuffer unused during adaptive sampling #20

Open
Solicey opened this issue May 6, 2024 · 1 comment
Open

Comments

@Solicey
Copy link

Solicey commented May 6, 2024

InterlockedExchange(g_ScreenProbes_ProbeSpawnBuffer[index], ScreenProbes_PackSeed(seed), index);

should be changed to:

InterlockedExchange(g_ScreenProbes_ProbeSpawnBuffer[g_ScreenProbes_OverrideTileBuffer[index]], ScreenProbes_PackSeed(seed), index);

so as to match with the GI-1.0 technical report.

@gboisse
Copy link
Collaborator

gboisse commented May 7, 2024

Thanks for reporting this, and you're correct, good spotting.
We fixed this internally already and will include the fix in a subsequent update of Capsaicin.

Hineven added a commit to Hineven/Capsaicin that referenced this issue Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants