Reintegrate ckanext-spatial upstream into catalog.data.gov

[btylerburton]

User Story

In order to reduce our maintenance burden, Data.gov team wants investigate whether we can reintegrate catalog.data.gov with the upstream version of the ckanext-spatial extension.

Reference:

• GSA/ckanext-spatial

Acceptance Criteria

[ACs should be clearly demoable/verifiable whenever possible. Try specifying them using BDD.]

• GIVEN [a contextual precondition]
  [AND optionally another precondition]
  WHEN [a triggering event] happens
  THEN [a verifiable outcome]
  [AND optionally another verifiable outcome]

Background

[Any helpful contextual notes or links to artifacts/evidence, if needed]

Security Considerations (required)

[Any security concerns that might be implicated in the change. "None" is OK, just be explicit here!]

Sketch

• Check if catalog builds and functions correctly with ckanext-spatial upstream.
  • Reintegrate with upstream.

[jbrown-xentity]

We should make sure our fork of ckanext-spatial is as up to date as possible. Review recent PR's to see if anything needs to be merged upstream, or any other fixes.
One specific item Update Package Schema for Tags will not be merged. We should take out this code and put it in https://github.com/GSA/ckanext-datagovcatalog. And document the crap out of it.

[nickumia-reisys]

Our customizations:

• (Old) Documentation changes ckanext-spatial#9
  • Overwritten by: Fast forward to upstream ckanext-spatial#10
• use the appropriate text_type for py2 and py3 for waf harvester ckanext-spatial#11
• Update package schema for tags ckanext-spatial#12
• Move datasets to delete first in line ckanext-spatial#14
• fixes type error when traversing subfolders ckanext-spatial#16

Merged (or at least started) Upstream:

• Update for PY3 Encoding (waf harvester) ckan/ckanext-spatial#252
• Apply byte->str conversion to recursive call ckan/ckanext-spatial#278
• Move datasets to delete first in line ckan/ckanext-spatial#261

TODO:

• Move package schema update for tags to different extension

[nickumia-reisys]

Only one customization is not captured and I believe it is not critical.

• Move datasets to delete first in line ckan/ckanext-spatial#261

Can you confirm @jbrown-xentity?

[nickumia-reisys]

It was determined that the above changes may cause issues, but will be taken care of in a separate ticket.