From 149f019614c8dd312d596e17b49e831ad73d41a0 Mon Sep 17 00:00:00 2001
From: Jared Bain <jared.bain@gsa.gov>
Date: Mon, 2 Dec 2024 12:50:18 -0500
Subject: [PATCH 1/7] create PR for fellow page breadcrumb

---
 _layouts/fellow.html | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/_layouts/fellow.html b/_layouts/fellow.html
index fdce0e04..d47b9f34 100644
--- a/_layouts/fellow.html
+++ b/_layouts/fellow.html
@@ -43,4 +43,5 @@ <h2>{{page.title}}</h2>
   <section class="usa-section">
     {% include last-modified.html %}
     {% include_cached touchpoint-survey-script.html %}
-  </section>
\ No newline at end of file
+  </section>
+  
\ No newline at end of file

From 6979c849892f3907383fabf152010fcc379edc99 Mon Sep 17 00:00:00 2001
From: Jared Bain <jared.bain@gsa.gov>
Date: Tue, 3 Dec 2024 10:04:24 -0500
Subject: [PATCH 2/7] Add breadcrumb to fellow pages

---
 _layouts/fellow.html | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/_layouts/fellow.html b/_layouts/fellow.html
index d47b9f34..f68a00c7 100644
--- a/_layouts/fellow.html
+++ b/_layouts/fellow.html
@@ -12,6 +12,27 @@
       <div class="grid-row grid-gap">
         {% include fellow-aside.html fellow_project=page.project fellow_agency=page.agency fellow_year=page.fellow_year fellow_hometown=page.hometown fellow_track=page.track fellow_education=page.university %}
         <div class="usa-layout-docs__main desktop:grid-col-9 usa-prose">
+          <!-- BREADCRUMB -->
+           <div>
+            <nav class="usa-breadcrumb usa-breadcrumb--wrap" aria-label="Breadcrumbs,,,">
+              <ol class="usa-breadcrumb__list">
+                <li class="usa-breadcrumb__list-item">
+                  <a href="{{site.baseurl}}" class="usa-breadcrumb__link"><span>Home</span></a>
+                </li>
+                <li class="usa-breadcrumb__list-item">
+                  <a href="{{site.baseurl}}/fellows" class="usa-breadcrumb__link"
+                    ><span>Fellows</span></a
+                  >
+                </li>
+                <li class="usa-breadcrumb__list-item usa-current" aria-current="page">
+                  <span
+                    >{{page.title}}</span
+                  >
+                </li>
+              </ol>
+            </nav>
+           </div>
+
          <h2>{{page.title}}</h2>
          <!-- <p class="usa-intro">
            {{ page.bio_short }}

From 9294b1fd94f86722894a49094decc565ab94a098 Mon Sep 17 00:00:00 2001
From: Jared Bain <jared.bain@gsa.gov>
Date: Tue, 3 Dec 2024 10:46:15 -0500
Subject: [PATCH 3/7] fix navigation arrow

---
 _sass/pages/_fellows.scss             | 4 ++++
 assets/images/icons/navigate_next.svg | 1 +
 2 files changed, 5 insertions(+)
 create mode 100644 assets/images/icons/navigate_next.svg

diff --git a/_sass/pages/_fellows.scss b/_sass/pages/_fellows.scss
index cb5d233a..2c49651b 100644
--- a/_sass/pages/_fellows.scss
+++ b/_sass/pages/_fellows.scss
@@ -229,4 +229,8 @@
 
   .fellow-funFact{
     @include u-padding-top(4);
+  }
+
+  .usa-breadcrumb__list-item:not(:last-child)::after {
+    mask: url(/assets/images/icons/navigate_next.svg) no-repeat center / contain;
   }
\ No newline at end of file
diff --git a/assets/images/icons/navigate_next.svg b/assets/images/icons/navigate_next.svg
new file mode 100644
index 00000000..fcb1a710
--- /dev/null
+++ b/assets/images/icons/navigate_next.svg
@@ -0,0 +1 @@
+<svg xmlns="http://www.w3.org/2000/svg" height="24" viewBox="0 0 24 24" width="24"><path d="M0 0h24v24H0z" fill="none"/><path d="M10 6L8.59 7.41 13.17 12l-4.58 4.59L10 18l6-6z"/></svg>

From b30606b00f9a75d4e4b363fa1283302a77442b5d Mon Sep 17 00:00:00 2001
From: Jared Bain <jared.bain@gsa.gov>
Date: Tue, 3 Dec 2024 10:51:53 -0500
Subject: [PATCH 4/7] update url

---
 _sass/pages/_fellows.scss | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/_sass/pages/_fellows.scss b/_sass/pages/_fellows.scss
index 2c49651b..d2db1a56 100644
--- a/_sass/pages/_fellows.scss
+++ b/_sass/pages/_fellows.scss
@@ -232,5 +232,5 @@
   }
 
   .usa-breadcrumb__list-item:not(:last-child)::after {
-    mask: url(/assets/images/icons/navigate_next.svg) no-repeat center / contain;
+    mask: url(../images/icons/navigate_next.svg) no-repeat center / contain;
   }
\ No newline at end of file

From a70cea6221c149519442a42ded5e7a5cd9502a59 Mon Sep 17 00:00:00 2001
From: Jared Bain <jared.bain@gsa.gov>
Date: Tue, 3 Dec 2024 11:53:19 -0500
Subject: [PATCH 5/7] Add no results found to fellow filters

---
 _includes/fellows-list.html | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/_includes/fellows-list.html b/_includes/fellows-list.html
index c5c36b17..59a2b468 100644
--- a/_includes/fellows-list.html
+++ b/_includes/fellows-list.html
@@ -1,4 +1,6 @@
 {% assign aria_id = fellow.title | url_encode | truncate: 15, "" %}
+
+{% if paginator.posts.size > 0 %}
 {% for fellow in paginator.posts %}
 <div class="fellow-card">
   <a href="{{ site.baseurl }}{{ fellow.url }}" aria-labelledby="{{ aria_id }}">
@@ -22,5 +24,9 @@ <h2 class="body-intro--bold" id="{{ aria_id }}">{{ fellow.title }}</h2>
 </div>
 
 {% endfor %}
-
+{% else %}
+<div class="no-results" style="padding-left:10px;">
+  <p> No results found. </p>
+</div>
+{% endif %}
 

From 617f3cbdffcd6b9fe35b9c015e5169b01c867e21 Mon Sep 17 00:00:00 2001
From: Jared Bain <jared.bain@gsa.gov>
Date: Tue, 3 Dec 2024 14:48:15 -0500
Subject: [PATCH 6/7] add alt to breadcrumb links

---
 _layouts/fellow.html | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/_layouts/fellow.html b/_layouts/fellow.html
index f68a00c7..ffde1ddd 100644
--- a/_layouts/fellow.html
+++ b/_layouts/fellow.html
@@ -17,11 +17,11 @@
             <nav class="usa-breadcrumb usa-breadcrumb--wrap" aria-label="Breadcrumbs,,,">
               <ol class="usa-breadcrumb__list">
                 <li class="usa-breadcrumb__list-item">
-                  <a href="{{site.baseurl}}" class="usa-breadcrumb__link"><span>Home</span></a>
+                  <a href="{{site.baseurl}}/"  class="usa-breadcrumb__link" ><span alt="Home">Home</span></a>
                 </li>
                 <li class="usa-breadcrumb__list-item">
                   <a href="{{site.baseurl}}/fellows" class="usa-breadcrumb__link"
-                    ><span>Fellows</span></a
+                    ><span alt="Fellow Page">Fellows</span></a
                   >
                 </li>
                 <li class="usa-breadcrumb__list-item usa-current" aria-current="page">
@@ -65,4 +65,3 @@ <h2>{{page.title}}</h2>
     {% include last-modified.html %}
     {% include_cached touchpoint-survey-script.html %}
   </section>
-  
\ No newline at end of file

From 8393ddaee3fc95cd63fd65a9d3b083123622d168 Mon Sep 17 00:00:00 2001
From: Jared Bain <jared.bain@gsa.gov>
Date: Tue, 3 Dec 2024 15:15:23 -0500
Subject: [PATCH 7/7] remove period

---
 _includes/fellows-list.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/_includes/fellows-list.html b/_includes/fellows-list.html
index 59a2b468..18b51cad 100644
--- a/_includes/fellows-list.html
+++ b/_includes/fellows-list.html
@@ -26,7 +26,7 @@ <h2 class="body-intro--bold" id="{{ aria_id }}">{{ fellow.title }}</h2>
 {% endfor %}
 {% else %}
 <div class="no-results" style="padding-left:10px;">
-  <p> No results found. </p>
+  <p> No results found </p>
 </div>
 {% endif %}