From 060a80b5985e092248f1a50676c82818ebc6f508 Mon Sep 17 00:00:00 2001
From: scottqueen-bixal
Date: Mon, 23 Dec 2024 15:27:30 -0500
Subject: [PATCH 01/11] PXBF-2014-design-qa-tweaks: bold content on notices
intro
---
.../src/App/__tests__/__snapshots__/index.spec.jsx.snap | 5 ++++-
.../Routes/Intro/__tests__/__snapshots__/index.spec.jsx.snap | 5 ++++-
.../NoticesList/__tests__/__snapshots__/index.spec.jsx.snap | 5 ++++-
benefit-finder/src/shared/locales/en/en.json | 2 +-
benefit-finder/src/shared/locales/es/es.json | 2 +-
5 files changed, 14 insertions(+), 5 deletions(-)
diff --git a/benefit-finder/src/App/__tests__/__snapshots__/index.spec.jsx.snap b/benefit-finder/src/App/__tests__/__snapshots__/index.spec.jsx.snap
index a7f5bf28..fc95a33b 100644
--- a/benefit-finder/src/App/__tests__/__snapshots__/index.spec.jsx.snap
+++ b/benefit-finder/src/App/__tests__/__snapshots__/index.spec.jsx.snap
@@ -166,7 +166,10 @@ exports[`loads intro 1`] = `
with each agency.
- We do not share, save, or submit your information.
+
+ We do not share, save, or submit
+
+ your information.
diff --git a/benefit-finder/src/Routes/Intro/__tests__/__snapshots__/index.spec.jsx.snap b/benefit-finder/src/Routes/Intro/__tests__/__snapshots__/index.spec.jsx.snap
index 8eb8970d..e308c488 100644
--- a/benefit-finder/src/Routes/Intro/__tests__/__snapshots__/index.spec.jsx.snap
+++ b/benefit-finder/src/Routes/Intro/__tests__/__snapshots__/index.spec.jsx.snap
@@ -151,7 +151,10 @@ exports[`Intro > renders a match to the previous snapshot 1`] = `
with each agency.
- We do not share, save, or submit your information.
+
+ We do not share, save, or submit
+
+ your information.
diff --git a/benefit-finder/src/shared/components/NoticesList/__tests__/__snapshots__/index.spec.jsx.snap b/benefit-finder/src/shared/components/NoticesList/__tests__/__snapshots__/index.spec.jsx.snap
index 7dcc7331..1460b272 100644
--- a/benefit-finder/src/shared/components/NoticesList/__tests__/__snapshots__/index.spec.jsx.snap
+++ b/benefit-finder/src/shared/components/NoticesList/__tests__/__snapshots__/index.spec.jsx.snap
@@ -43,7 +43,10 @@ exports[`NoticesList > renders a match to the previous snapshot 1`] = `
with each agency.
- We do not share, save, or submit your information.
+
+ We do not share, save, or submit
+
+ your information.
diff --git a/benefit-finder/src/shared/locales/en/en.json b/benefit-finder/src/shared/locales/en/en.json
index 1d4e44f8..6010535f 100644
--- a/benefit-finder/src/shared/locales/en/en.json
+++ b/benefit-finder/src/shared/locales/en/en.json
@@ -20,7 +20,7 @@
"iconAlt": "Important",
"list": [
{
- "notice": "This is not an application. You will need to apply for benefits with each agency.
We do not share, save, or submit your information.
"
+ "notice": "This is not an application. You will need to apply for benefits with each agency.
We do not share, save, or submit your information.
"
}
]
},
diff --git a/benefit-finder/src/shared/locales/es/es.json b/benefit-finder/src/shared/locales/es/es.json
index c07da0c9..435f780b 100644
--- a/benefit-finder/src/shared/locales/es/es.json
+++ b/benefit-finder/src/shared/locales/es/es.json
@@ -20,7 +20,7 @@
"iconAlt": "Importante",
"list": [
{
- "notice": "Esto no es una aplicación. Necesita presentar una solicitud con cada agencia.
No guardamos ni compartimos sus respuestas con ninguna agencia.
"
+ "notice": "Esto no es una aplicación. Necesita presentar una solicitud con cada agencia.
No guardamos ni compartimos sus respuestas con ninguna agencia.
"
}
]
},
From e374ab77806a03641fd2818f9fd891b42eee91dd Mon Sep 17 00:00:00 2001
From: scottqueen-bixal
Date: Mon, 23 Dec 2024 15:31:25 -0500
Subject: [PATCH 02/11] PXBF-2014-design-qa-tweaks: margin adjustment to
cta-wrapper
---
benefit-finder/src/Routes/Intro/_index.scss | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/benefit-finder/src/Routes/Intro/_index.scss b/benefit-finder/src/Routes/Intro/_index.scss
index 1db31229..aeace740 100644
--- a/benefit-finder/src/Routes/Intro/_index.scss
+++ b/benefit-finder/src/Routes/Intro/_index.scss
@@ -12,7 +12,7 @@
.bf-cta-wrapper {
display: flex;
justify-content: center;
- margin: rem(20px) 0 rem(56px);
+ margin: rem(20px) 0 rem(24px);
@media (width >= $desktop) {
margin: rem(32px) rem(32px) rem(64px);
@@ -32,7 +32,7 @@
margin-left: rem(16px);
}
- .bf-intro-process-notices-heading {
+ .bf-intro-process-notices-heading {
width: 100;
margin-bottom: rem(30px);
}
@@ -59,14 +59,14 @@
.bf-usa-process-list {
margin-left: 0;
margin-right: 0;
- padding-top:rem(8px);
+ padding-top: rem(8px);
.bf-usa-process-list__heading {
font-size: rem(16px);
- @media (width >= $desktop) {
- font-size: rem(21px);
- }
+ @media (width >= $desktop) {
+ font-size: rem(21px);
+ }
}
}
}
From 05a0d182877149f5c73bc94eb52e3a3c1f5335c5 Mon Sep 17 00:00:00 2001
From: scottqueen-bixal
Date: Mon, 23 Dec 2024 15:37:11 -0500
Subject: [PATCH 03/11] PXBF-2015-design-qa-tweaks: adjust container pading on
verification view
---
benefit-finder/src/Routes/LifeEventSection/_index.scss | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/benefit-finder/src/Routes/LifeEventSection/_index.scss b/benefit-finder/src/Routes/LifeEventSection/_index.scss
index 01407f33..af95097c 100644
--- a/benefit-finder/src/Routes/LifeEventSection/_index.scss
+++ b/benefit-finder/src/Routes/LifeEventSection/_index.scss
@@ -11,7 +11,7 @@
.bf-grid-container.grid-container {
max-width: $form-container-max-width;
- padding: 0 rem(36px);
+ padding: 0 rem(20px);
@media (width >= calc($form-container-max-width + rem(24px))) {
padding-left: 0;
From b4585b368f9daf1cfb513aa369ddfc4a655a7639 Mon Sep 17 00:00:00 2001
From: scottqueen-bixal
Date: Mon, 23 Dec 2024 15:49:39 -0500
Subject: [PATCH 04/11] PXBF-2016-design-qa-tweaks: hide expand all button on
mobile
---
.../ResultsView/components/Results/_index.scss | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/benefit-finder/src/Routes/ResultsView/components/Results/_index.scss b/benefit-finder/src/Routes/ResultsView/components/Results/_index.scss
index 5e1a7e98..08c69a62 100644
--- a/benefit-finder/src/Routes/ResultsView/components/Results/_index.scss
+++ b/benefit-finder/src/Routes/ResultsView/components/Results/_index.scss
@@ -4,9 +4,9 @@
@use '@styles/functions' as *;
.bf-result-view {
- .bf-grid-container.grid-container {
- padding: rem(20px);
- }
+ .bf-grid-container.grid-container {
+ padding: rem(20px);
+ }
}
.bf-result-view-benefits,
@@ -21,6 +21,10 @@
.bf-result-view-share-results-heading {
@include h3;
}
+
+ .bf-expand-all {
+ display: none;
+ }
}
.bf-result-view-unmet {
@@ -48,4 +52,8 @@
.bf-result-view-details {
padding: rem(24px) 5.4rem;
}
+
+ .bf-result-view-benefits .bf-expand-all {
+ display: block;
+ }
}
From d67085ba26bfea87e6fa5a57e928ff3435d19f5a Mon Sep 17 00:00:00 2001
From: scottqueen-bixal
Date: Mon, 23 Dec 2024 15:50:44 -0500
Subject: [PATCH 05/11] PXBF-2016-design-qa-tweaks: update content for cta
---
.../ResultsView/__tests__/__snapshots__/index.spec.jsx.snap | 4 ++--
benefit-finder/src/shared/locales/en/en.json | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/benefit-finder/src/Routes/ResultsView/__tests__/__snapshots__/index.spec.jsx.snap b/benefit-finder/src/Routes/ResultsView/__tests__/__snapshots__/index.spec.jsx.snap
index 6a1bd88f..3625590d 100644
--- a/benefit-finder/src/Routes/ResultsView/__tests__/__snapshots__/index.spec.jsx.snap
+++ b/benefit-finder/src/Routes/ResultsView/__tests__/__snapshots__/index.spec.jsx.snap
@@ -6215,7 +6215,7 @@ exports[`loads view 1`] = `
data-testid="bf-result-view-unmet-button"
type="button"
>
- Explore benefits you did not qualify for
+ See benefits you didn't qualify for
@@ -12554,7 +12554,7 @@ exports[`scenario 1 loads in view with the correct amount of likely eligible ite
data-testid="bf-result-view-unmet-button"
type="button"
>
- Explore benefits you did not qualify for
+ See benefits you didn't qualify for
diff --git a/benefit-finder/src/shared/locales/en/en.json b/benefit-finder/src/shared/locales/en/en.json
index 6010535f..584b6f9d 100644
--- a/benefit-finder/src/shared/locales/en/en.json
+++ b/benefit-finder/src/shared/locales/en/en.json
@@ -153,7 +153,7 @@
"notEligibleResults": {
"heading": "Benefits you did not qualify for",
"description": "Based on your answers you are not eligible for these benefits. You may become eligible if you enter additional information or your situation changes.
",
- "cta": "Explore benefits you did not qualify for"
+ "cta": "See benefits you didn't qualify for"
},
"resultsRelativeBenefits": {
"heading": "More benefits"
From 83ddf93b412fb1c2888e99dc5a12d17e66441ae5 Mon Sep 17 00:00:00 2001
From: scottqueen-bixal
Date: Mon, 23 Dec 2024 16:02:00 -0500
Subject: [PATCH 06/11] PXBF-2016-design-qa-tweaks: bold content and include
createMarkup
---
.../__tests__/__snapshots__/index.spec.jsx.snap | 14 ++++++++++++--
.../__tests__/__snapshots__/index.spec.jsx.snap | 7 ++++++-
.../ResultsView/components/Results/index.jsx | 2 +-
benefit-finder/src/shared/locales/en/en.json | 2 +-
benefit-finder/src/shared/locales/es/es.json | 2 +-
5 files changed, 21 insertions(+), 6 deletions(-)
diff --git a/benefit-finder/src/Routes/ResultsView/__tests__/__snapshots__/index.spec.jsx.snap b/benefit-finder/src/Routes/ResultsView/__tests__/__snapshots__/index.spec.jsx.snap
index 3625590d..9595482c 100644
--- a/benefit-finder/src/Routes/ResultsView/__tests__/__snapshots__/index.spec.jsx.snap
+++ b/benefit-finder/src/Routes/ResultsView/__tests__/__snapshots__/index.spec.jsx.snap
@@ -6303,7 +6303,12 @@ exports[`loads view 1`] = `
Share results
- Copy or email these results. Your answers will be visible. Only share with those you trust.
+ Copy or email these results. Your answers will be visible.
+
+ Only share with those you trust
+
+ .
+