Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulate prism observations #1018

Open
rmjarvis opened this issue Mar 21, 2019 · 4 comments
Open

Simulate prism observations #1018

rmjarvis opened this issue Mar 21, 2019 · 4 comments
Assignees
Labels
feature request Request for a new feature in GalSim roman Relevant to Roman Space Telescope specifically, especially including the galsim.roman module.

Comments

@rmjarvis
Copy link
Member

rmjarvis commented Mar 21, 2019

Rebekah Hounsell wants to use GalSim to simulate prism observations from Roman. This mostly involves implementing an old (and closed because part of it was done) issue of 1-d degenerate objects. In this case, the 1-d function would be the SED in the direction of the prism dispersion.

@rmjarvis rmjarvis added feature request Request for a new feature in GalSim roman Relevant to Roman Space Telescope specifically, especially including the galsim.roman module. labels Mar 21, 2019
@matroxel matroxel self-assigned this Feb 16, 2024
@matroxel
Copy link
Contributor

Working on this with SN PIT. First prototype prism model implemented as photon op in https://github.com/matroxel/roman_imsim/blob/prism/roman_imsim/photonOps.py

Need to update some roman module things to enable prism elements that we had previously never implemented, which will happen in this branch.

@arunkannawadi
Copy link
Member

I think I'll take this issue over from Troxel. I have computed sky backgrounds corresponding to prism and grism, but noticing that I don't get the current values for the other filters exactly. I know they are accurate to only 10% or so, but I was hoping to get the exact values reproduced by existing filters as a cross check. I'll raise a PR later today so we can see if they seem reasonable.

@arunkannawadi
Copy link
Member

Troxel tells me that @rmandelb is integrating the code to compute the sky backgrounds on the fly instead of using a lookup table. That's great!

But in the mean time, could we not use the sky backgrounds for SNPrism that are already here? I see that it was added in #1017 however, the sky level for prism and grism bands continue to be skipped here: https://github.com/GalSim-developers/GalSim/blob/releases/2.5/galsim/roman/roman_bandpass.py#L138-L139

Can we remove those lines?

@rmandelb
Copy link
Member

Hi @arunkannawadi - For now, for various practical reasons, I have integrated the code to compute sky backgrounds on the fly (based on Troxel's port of Chris's ETC code, with both of their permission) into a separate repo in which we are developing tools for Euclid-like simulations. However, the idea is to make that public soon. If we then want to move that out of the Euclid-like code base and into GalSim, that would be fine.

@arunkannawadi arunkannawadi linked a pull request Jul 31, 2024 that will close this issue
@arunkannawadi arunkannawadi added this to the v2.6 milestone Jul 31, 2024
@rmjarvis rmjarvis removed this from the v2.6 milestone Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature in GalSim roman Relevant to Roman Space Telescope specifically, especially including the galsim.roman module.
Projects
None yet
Development

No branches or pull requests

4 participants