Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and possibly remove additional morphic patches in JfP #159

Closed
ericwinger opened this issue Jan 2, 2025 · 1 comment
Closed

Review and possibly remove additional morphic patches in JfP #159

ericwinger opened this issue Jan 2, 2025 · 1 comment
Assignees
Labels
F3-Enhancement Feature for convenience or ease of use

Comments

@ericwinger
Copy link
Member

There were a number of morphic walkbacks that had to be worked around in JfP when development was being done in Pharo 11. Now that JfP is only available with Pharo 12, it was suggested to remove these patches.

The suggested patches are here #149 (comment) (see below)

Need to review and test without these patches.

"Thanks! There are a few similar patches to other methods that should perhaps be removed as well: #recomputeSelection on RubAbstractTextArea, #drawOn: on RubLineNumberDisplayer, #drawOn: on RubOpeningClosingDelimiterDecorator, #whenExtentChanged: on RubTextSegmentMorph, and #computeVertices on RubUnderlinedSegmentMorph (which conflicts with the changes of Pharo commit 1046ab4f05)."

@ericwinger ericwinger added the F3-Enhancement Feature for convenience or ease of use label Jan 2, 2025
@ericwinger ericwinger self-assigned this Jan 2, 2025
ericwinger added a commit that referenced this issue Feb 6, 2025
removed overrides - committing to run full test suite

#159
@ericwinger
Copy link
Member Author

I pulled the overrides and ran the tests which passed. We'll need to keep an eye out for red X boxes of death and restore overrides if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F3-Enhancement Feature for convenience or ease of use
Projects
None yet
Development

No branches or pull requests

1 participant