Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include fullscreen button in embed pages #1879

Closed
allyoucanmap opened this issue Oct 10, 2024 · 0 comments · Fixed by #1880 or #1883
Closed

Include fullscreen button in embed pages #1879

allyoucanmap opened this issue Oct 10, 2024 · 0 comments · Fixed by #1880 or #1883
Assignees
@allyoucanmap
Labels
enhancement New feature or request geonode-ui
Milestone
4.4.1

Comments

@allyoucanmap
Copy link
Collaborator

We should allow to include the fullscreen button in the embed pages.
Requirements:

  • the share embed url should be converted to a snippet including the iframe
  • a checkbox below the embed url will allow the user to choose to include the fullscreen button
  • the fullscreen button should be added to the embed page only if the allowFullscreen=true query parameter is added to the embed url

image
@allyoucanmap allyoucanmap added this to the 4.4.1 milestone Oct 10, 2024
@allyoucanmap allyoucanmap self-assigned this Oct 10, 2024
@allyoucanmap allyoucanmap linked a pull request Oct 10, 2024 that will close this issue
Fix #1879 Include fullscreen button in embed pages #1880
Merged
@allyoucanmap allyoucanmap added the enhancement New feature or request label Oct 10, 2024
giohappy pushed a commit that referenced this issue Oct 10, 2024
@allyoucanmap
Fix #1879 Include fullscreen button in embed pages (#1880)
5821ad2
@allyoucanmap allyoucanmap linked a pull request Oct 16, 2024 that will close this issue
[Backport 4.4.x] Fix #1879 Include fullscreen button in embed pages (#1880) #1883
Merged
giohappy pushed a commit that referenced this issue Oct 16, 2024
@allyoucanmap
Fix #1879 Include fullscreen button in embed pages (#1880) (#1883)
936c1be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@allyoucanmap allyoucanmap

Labels
enhancement New feature or request geonode-ui
Projects
None yet
Milestone
4.4.1
1 participant
@allyoucanmap