Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collaboration opportunity? #16

Open
ibgreen opened this issue Sep 13, 2019 · 5 comments
Open

Collaboration opportunity? #16

ibgreen opened this issue Sep 13, 2019 · 5 comments
Assignees

Comments

@ibgreen
Copy link

ibgreen commented Sep 13, 2019

Hi, very nice demo, thanks for sharing.

We are also developing a framework-independent 3d tile loader (part of our loaders.gl effort), you can see results developing at:

A few remarks:

  • We created loaders.gl to enable collaboration/interoperability with others developers, such as yourselves.
  • As you have probably discovered, implementing the full 3d tiles standard is a big effort and as such, best shared.
  • If collaboration sounds interesting, happy to connect.

Also:

  • Could you clarify the licenses on your open source code, ideally by adding a LICENSE file to your repo? As it stands, it is not clear whether we can use/copy/fork your code
  • One idea would be to port your mapbox/THREE.js sample to use the loaders.gl/3d-tiles loader and include as a demo on loaders.gl website (with attribution to yourselves of course!)
  • If we can't use your implementation as a base due to licensing issues that is OK, we'd likely roll our own, but why reinvent the wheel when working with open source?
@tomvantilburg tomvantilburg self-assigned this Sep 16, 2019
@tomvantilburg
Copy link
Member

Hi @ibgreen, we weren't aware of the current efforts on 3d-tiles in loaders.gl, thanks so much for sharing! We will look into it.

In the meantime some answers:

  • As far as we are aware there is a LICENSE file with a BSD-3 license in the repository.
  • We are currently using the THREE.GLTFLoader(); to load the gltf models that are inside the 3D-tiles. I assume you are also using this function from THREEjs? Do you have an example implementation of that? I only saw a pointcloud implementation in your online examples.

@ibgreen
Copy link
Author

ibgreen commented Sep 16, 2019

As far as we are aware there is a LICENSE file with a BSD-3 license in the repository.

@tomvantilburg Yes there it is! Don't know how I could have missed that. Awesome, thanks!

@ibgreen
Copy link
Author

ibgreen commented Sep 16, 2019

We are currently using the THREE.GLTFLoader(); to load the gltf models that are inside the 3D-tiles. I assume you are also using this function from THREEjs?

We don't, as I will explain below, however you can take the extracted GLB data from the Tile3DLoader and pass to THREE.GLTFLoader.

@ibgreen
Copy link
Author

ibgreen commented Sep 16, 2019

As context, loaders.gl is a suite of framework-independent loaders. The idea is that they can be used with any WebGL framework.

We currently only have an integration with our own https://deck.gl framework Tile3DLayer

But we'd love to be able to showcase a THREE.js integration as well, and your code would be a perfect baseline to build that example on.

If you are interested in using loaders.gl as a base we could collaborate on porting your THREE.js based example to loaders.gl.

We'd both benefit from sharing a common implementation of this quite complex standard, and we could share work on optimizing loading and traversal etc.

@ibgreen
Copy link
Author

ibgreen commented Sep 20, 2019

@tomvantilburg Quick update

The current port uses loaders.gl to parse the tiles, but does not yet use loaders.gl traversal algorithm, see the pull request for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants