From c0cd36c7573487f46256e5c01e927951f18e44c0 Mon Sep 17 00:00:00 2001 From: Evan Welsh <2943271+ewlsh@users.noreply.github.com> Date: Tue, 25 Aug 2020 13:41:22 -0500 Subject: [PATCH] Avoid network authentication calls if unnecessary. If a token is invalid locally, it will also be invalid on a network call. Network calls only detect if a valid token has since been revoked. --- src/middleware/auth/middleware.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/middleware/auth/middleware.ts b/src/middleware/auth/middleware.ts index a34d9e4..f7a7c82 100644 --- a/src/middleware/auth/middleware.ts +++ b/src/middleware/auth/middleware.ts @@ -23,7 +23,9 @@ export function initializeAuth(auth: auth.Auth) { const [, idToken] = parts; auth - .verifyIdToken(idToken, true) + .verifyIdToken(idToken) + // Only confirm that a token hasn't been revoked _after_ we are sure it is a valid token. + .then(() => auth.verifyIdToken(idToken, true)) .then(claims => { return claims.admin === true; })