Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChannelList is recomposed when some events are arrived #4389

Closed
workspace opened this issue Nov 10, 2022 · 1 comment
Closed

ChannelList is recomposed when some events are arrived #4389

workspace opened this issue Nov 10, 2022 · 1 comment
Assignees
Labels
bug Something isn't working sdk-issue Used for issues/bugs opened/reported by customers or us.

Comments

@workspace
Copy link
Contributor

workspace commented Nov 10, 2022

Describe the bug
ChannelList is recomposed too many times when some events are arrived, however, I'm not sure this behavior is bug because item in LazyColumn (such as DefaultChannelItem) skip recomposition.

SDK version
5.11.3 (latest)

To Reproduce
Steps to reproduce the behavior:

  1. Prepare 2 devices, accounts(call them A, B) which has a common channel.
  2. watch channel list in A
  3. watch channel list in B -> UserStartWatchingEvent is arrived in A -> channel list in A is recomposed
  4. enter the common channel in B -> MessageReadEvent is arrived A -> channel list in A is recomposed

Expected behavior
recomposition should be occurred in channel which has changes

Device:

  • Android 13, Pixel 4
  • Anroid 12, Galaxy Fold 1

Screenshots
device A : Galaxy Fold with layout inspector
device B : Pixel 4 which produces UserStartWatchingEvent and MessageReadEvent.

IMG_0237.mov
@workspace workspace added the bug Something isn't working label Nov 10, 2022
@MarinTolic MarinTolic self-assigned this Nov 15, 2022
@filbabic filbabic added the sdk-issue Used for issues/bugs opened/reported by customers or us. label Feb 7, 2023
@DanielNovak
Copy link
Contributor

Closing due to inactivity - but many improvements have been made since then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sdk-issue Used for issues/bugs opened/reported by customers or us.
Projects
Status: Merged
Development

No branches or pull requests

4 participants