Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InputField background shape not aligned with border #5429

Closed
AlanChienHouzz opened this issue Oct 4, 2024 · 1 comment · Fixed by #5428
Closed

InputField background shape not aligned with border #5429

AlanChienHouzz opened this issue Oct 4, 2024 · 1 comment · Fixed by #5428
Labels
bug Something isn't working

Comments

@AlanChienHouzz
Copy link

AlanChienHouzz commented Oct 4, 2024 •
edited
Loading

Describe the bug
The InputField background shape not aligned with border if border's shape higher then 4 dp

Commit: 027a606
Code: 027a606#r147561735

I customized inputField's shape. It will cause the background still keep 16 dp because of you use pollOptionInput to clip. not sure if it's expected?

            val shapes = StreamShapes.defaultShapes().copy(
                inputField = RoundedCornerShape(4.dp),
            )

to fix this we should also add

               pollOptionInput = RoundedCornerShape(4.dp)

Screenshots
Screenshot_20241004_113419
@AlanChienHouzz AlanChienHouzz added the bug Something isn't working label Oct 4, 2024
AlanChienHouzz referenced this issue Oct 4, 2024
@skydoves @kanat
Compose Poll creation UI attachment components (1) (#5305)
027a606 
* Implement AttachmentsPickerPollTabFactory and add it into the AttachmentsPickerTabFactory

* Implement animating content systems for the full screen attachment

* Implement PollOptionHeader and relevant actions

* Implement PollOptionInput and PollOptionQuestions composable components

* Improve full screen attachment height size animation and fix flickering bugs

* Implement maxLength parameter on PollOptionInput

* Rename poll components name

* Implement reoderable PollQuestionList and nested scroll

* Implement poll question list item following the design guidelines

* Improve reordering performance for PollQuestionList

* Refactor PollQuestionList to use PollOptionItem

* Refactor PollQuestionList

* implement eror handling for option item list creation

* Refactor to hold poll option item list

* Check if the title is not blank

* Implemetn PollCreationDiscardDialog Composable

* Implement the skeleton of the PollSwitchList and relevant data classes

* Complete PollSwitchList composable

* Implement poll switch inputs

* Add default options

* Update detekt baseline

* Fix docs module to work

* Import paparazzi plugin and implement BaseComposeTest

* Implement PollUITest and generate snapshot images

* Update detekt

* Implement AttachmentsPickerPollTabFactory and make poll tab items customizable

* Add missing docs for poll data classes

* Implement AttachmentPickerAction interface

* Update detektBaseline

* Update attachment docs

* Fix docs that are not related to v6 for attachment lambdas

---------

Co-authored-by: Kanat Kiialbaev <[email protected]>
@aleksandar-apostolov
Copy link
Collaborator

Hi @AlanChienHouzz

Its a bug, thanks for reporting it. pollOptionsInput is just for the input fields on the "Create poll" component.
We will update this issue when this is fixed.

Regards,
Alex

@aleksandar-apostolov aleksandar-apostolov linked a pull request Oct 7, 2024 that will close this issue
Fix the input border is using wrong shape #5428
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the input border is using wrong shape GetStream/stream-chat-android
2 participants
@aleksandar-apostolov @AlanChienHouzz