Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on web implementation due to missing battery and thermal implementations #836

Open
EvertonMJunior opened this issue Jan 23, 2025 · 2 comments

Comments

@EvertonMJunior
Copy link

Hello,

Running the package on web, I discovered a bug. On stream_video/src/call/sfu_stats_reporter.dart, there are two methods that are unimplemented in web being called, being isInBatterySaveMode() from package battery_plus, and getThermalStatus() from package thermal.
When trying to connect to a call, these errors are preventing the correct flow of the connection:

ErrorLogger
🛑 message: Error joining room
🛑 errorMessage: UnimplementedError: isInBatterySaveMode() has not been implemented.
🛑 errorKind: null
🛑 errorStackTrace: ../dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 288:3  
throw_
../packages/battery_plus_platform_interface/battery_plus_platform_interface.dart 47:5  get
isInBatterySaveMode
../packages/battery_plus/battery_plus.dart 44:22                                       get
isInBatterySaveMode
../packages/stream_video/src/call/sfu_stats_reporter.dart 77:42                        <fn>
...
DartError: MissingPluginException(No implementation found for method getThermalStatus on channel    
thermal)
@EvertonMJunior
Copy link
Author

The unavailability of the methods is advertised on:

battery_plus
Image

thermal (they are not as explicit in saying that calling the methods will yield in an exception, but they do say web is not supported)
Image

@EvertonMJunior
Copy link
Author

Just submitted #837 with the fix. The problem was solved on my end, hope you can reproduce it and verify it on your end!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant