-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iesdp project data should not contain symbolic links #160
Comments
Then we'd have to maintain two identical files, which sounds silly and is probably the reason why @burner1024 chose this approach. Is this a hypothetical problem? Git can handle this properly, so I don't see a big issue. On a filesystem with no support, the link file will have different content, so it will be obviously wrong to edit. |
It's a real problem (although it probably doesn't occur very often). Windows doesn't preserve links on copy operations or move operations across partition boundaries, and will be automatically turned into regular files. In my case it happened when I moved the local repo to another drive because of a disk upgrade. Also from what I've read, symlink support for git on Window must be explicitly enabled or symlinks will be turned into special text files (which apparently could cause issues with some git clients). |
I'm surprised you actually had a link, as the docs make it sound quite unlikely. But anyway, I think the occasional pain for contributors on windows is the lesser evil. YAML doesn't provide any inclusion mechanism either. |
I am using mostly Linux, but when I copy data from Linux to Windows, Windows causes issues. For instance, I once had a symlink from a directory called C++ or so, called c++ or c (the symlink I am mentioning this just as an example - windows is really a pain in regards to symlinks (and
This assumes that windows silently ignores it. But as my example showed of a symlink called |
https://github.com/Gibberlings3/iesdp/blob/master/_data/file_formats/spl_v1/feature_block.yml
is currently stored as a symbolic link.Symlinks are handled badly on Windows platforms and may cause issues when performing operations that directly or indirectly involve these files. I'd recommend to turn it into a regular file.
The text was updated successfully, but these errors were encountered: