Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Goblin Bow Elite (Quest) from ar1000 is too long a scripting name #3

Closed
lynxlynxlynx opened this issue Jun 29, 2023 · 2 comments
Closed

Minor: Goblin Bow Elite (Quest) from ar1000 is too long a scripting name #3

lynxlynxlynx opened this issue Jun 29, 2023 · 2 comments

Comments

@lynxlynxlynx
Copy link
Member

It's inconsequential now, but if anyone wanted to do anything with him, 24 chars is too long for eg. SPRITE_IS_DEAD* var formation, it would be cut off. Just needs a rename in the ARE.
@CamDawg
Copy link
Member

CamDawg commented Jan 27, 2025

Well, thanks for this rabbit hole. I've found 90 hits on script names > 18 across the game.

CamDawg added a commit that referenced this issue Jan 30, 2025
@CamDawg
I blame lynx for this
053954f 
#3

Since oIWD uses actor names from the area file as DVs, we need to limit them to 18 characters so that the dead variables
SPRITE_IS_DEADfoo don't exceed the 32-character limit.
@CamDawg
Copy link
Member

CamDawg commented Jan 30, 2025

Fixed in 053954f

@CamDawg CamDawg closed this as completed Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lynxlynxlynx @CamDawg