Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"if the infection rate depends on the number of infected neighbors" is inconsistent #258

Open
hadjipantelis opened this issue Dec 6, 2024 · 0 comments
Assignees

Comments

@hadjipantelis
Copy link

First of all, thank you for making ndlib it is great.

Describe the bug
The infection rate depends on the number of infected neighbors (tp_rate) but while this is implemented in the modes SI, SIS and SEIR this is not implemented in SIR or SWIR. To that extent, tp_rate is even declared in the SIRmodel (

) but then never used. Oddly, the documentation doesn't mention tp_rate, so the behaviour is inconsistent among otherwise similar models.

To Reproduce
Steps to reproduce the behavior:

  • NDlib version: 5.1.1
  • Operating System: Any
  • Python version: Any
  • Version(s) of NDlib required libraries: NA

Expected behavior
To use tp_rate throughout and allow the user to set it (if needed).

@GiulioRossetti GiulioRossetti self-assigned this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants