Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-organize raster and vector functionalities as separate functions #539

Open
rhugonnet opened this issue Apr 30, 2024 · 2 comments
Open
Assignees
Labels
architecture Need to re-organize or re-structure something priority

Comments

@rhugonnet
Copy link
Contributor

Already mentioned when discussing #383, we need to move out all function of Raster and Vector to live outside the class, both to facilitate the Xarray accessor and tests.

Here's an idea of structure, adding new modules:

In geoutils/:

raster/
-- accessor.py (Xarray raster accessor)
-- distance.py (proximity)
-- georef.py (for reproject, crop)

vector/
-- geometric.py (buffer_with_overlap)
-- georef.py (reproject, crop)

raster_vector_interface.py (rasterize, polygonize, create_mask, to_pointcloud)

@adehecq
Copy link
Member

adehecq commented May 28, 2024

I guess all these submodules would never have to be called by the user, as all the functions would be implemented as class methods? If so, this sounds good !

@rhugonnet
Copy link
Contributor Author

Yes exactly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture Need to re-organize or re-structure something priority
Projects
None yet
Development

No branches or pull requests

2 participants