Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py_sad_correlation #10

Open
ChasNelson1990 opened this issue Mar 5, 2020 · 4 comments
Open

py_sad_correlation #10

ChasNelson1990 opened this issue Mar 5, 2020 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@ChasNelson1990
Copy link
Member

Technically, this is a different project that hasn't been made open yet... but j_py_sad_correlation.sad_grid can't handle uint16 image sequences.

@ChasNelson1990 ChasNelson1990 added the bug Something isn't working label Mar 5, 2020
@ChasNelson1990 ChasNelson1990 self-assigned this Mar 5, 2020
@ChasNelson1990
Copy link
Member Author

Also, it can't handle being passed a list.

@ChasNelson1990
Copy link
Member Author

@jmtayloruk this is very much your area of expertise, I don't see why this can't be done? I believe it could be as simple as changing lines 235/6 in the cpp to include both uint8 and uint16?

@jmtayloruk
Copy link
Collaborator

Agree that it should not be hard to support uint16. It will require a slight rejig of the code as there are rather more instances than just those two lines, but this is what C++ templates are for.

A list would be a bit more of a faff and would probably require a completely separate code branch. Is this something you particularly need, or are you easily able to adapt your calling code to work with a 3D array?

@ChasNelson1990
Copy link
Member Author

I think we can ignore the list - I think there should be enough catches for that now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants