New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when name_resolver resource is searched pagination parameters are not global. #102

Open

dimus opened this issue Nov 11, 2016 · 1 comment

Labels

bug

Member

dimus commented Nov 11, 2016

page and perPage are returned inside of results for every name. They should be global parameters.

The text was updated successfully, but these errors were encountered:

dimus added the bug label

Contributor

alexander-myltsev commented Nov 17, 2016 •

edited

Loading

So, there is additional level of nested array then:

{
  "page": 1,
  "per_page": 1000,
  "items": [{
    "total": 1,
    "matches": []
  }, {
    "total": 2,
    "matches": []
  }]
}

How would we name items then?

alexander-myltsev added a commit that referenced this issue


          ! #102: make pagination result global in output

92d6407

dimus closed this as completed

dimus reopened this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment