Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent behavior in faceted search with "wrong" capitalization #98

Open
dimus opened this issue Nov 2, 2016 · 2 comments
Open
Labels

Comments

@dimus
Copy link
Member

dimus commented Nov 2, 2016

Uninomial search allows lowcase: "uni:algae" finds "Algae C. Linnaeus, 1753" from development db.

genus, species, author, susbspecies do not find records with wrong capitalization.

We need to make it consistent, lets decide what is better to ignore capitalization everywhere in name_string?search_term or not.

@dimus dimus added the bug label Nov 2, 2016
@alexander-myltsev
Copy link
Contributor

The reason why uni:aglae passes is that every search is first-letter capitalised before execution. We should discuss what kinds of searcher should be case agnostic.

@alexander-myltsev
Copy link
Contributor

alexander-myltsev commented Nov 9, 2016

Exact modifier: search as-is (even 2-or-more white spaces)

Canonical (+ wildcard): clean query ~> make capitalisation (if first two chars are not x<space>)

NameString:

  • search over name only (omit canonical match)
  • invariant of capitalisation, spaces, unicode

Genus, species, author, subspecies, year: capitalisation, spaces, unicode invariant search

No-modifiers:

  • wildcard less: parse name ~> (ns: + match over canonical)
  • wildcarded: don't parse name ~> full text search over DB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants